From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] lsm: mark the lsm_id variables are marked as static
Date: Sun, 12 Nov 2023 23:09:47 -0500 [thread overview]
Message-ID: <CAHC9VhRqVyJRaiUseJjFUYP_UFn_S+rDHNNNzcv2VbO0=9SJ4g@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhSdC-=vDK8ezhMe=ymL4vjNB1NPxi2pCAG5Uo1P0Z5fjA@mail.gmail.com>
On Fri, Nov 10, 2023 at 4:36 PM Paul Moore <paul@paul-moore.com> wrote:
> On Fri, Nov 10, 2023 at 3:23 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
> >
> > On 11/10/2023 9:34 AM, Paul Moore wrote:
> > > As the kernel test robot helpfully reminded us, all of the lsm_id
> > > instances defined inside the various LSMs should be marked as static.
> > > The one exception is Landlock which uses its lsm_id variable across
> > > multiple source files with an extern declaration in a header file.
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Suggested-by: Casey Schaufler <casey@schaufler-ca.com>
> > > Signed-off-by: Paul Moore <paul@paul-moore.com>
> >
> > Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
>
> Thanks Casey, I've gone ahead and merge this into lsm/dev-staging.
Merged into lsm/dev.
--
paul-moore.com
prev parent reply other threads:[~2023-11-13 4:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 17:34 [PATCH] lsm: mark the lsm_id variables are marked as static Paul Moore
2023-11-10 20:23 ` Casey Schaufler
2023-11-10 21:36 ` Paul Moore
2023-11-13 4:09 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhRqVyJRaiUseJjFUYP_UFn_S+rDHNNNzcv2VbO0=9SJ4g@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=casey@schaufler-ca.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).