From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B0AEE0210 for ; Wed, 13 Sep 2023 22:19:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232970AbjIMWTJ (ORCPT ); Wed, 13 Sep 2023 18:19:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232920AbjIMWTI (ORCPT ); Wed, 13 Sep 2023 18:19:08 -0400 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42C1C1999 for ; Wed, 13 Sep 2023 15:19:04 -0700 (PDT) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-59bbed7353aso5508577b3.0 for ; Wed, 13 Sep 2023 15:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1694643543; x=1695248343; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5pve2evvQG8Wu6dcM6eIRAvQq/3oe/203mcy+b19gA8=; b=JXbUn+C9hYr/UbHJPlAGR8ydV8unkggCBmeHKJrtstvUXX5xlvGSLHbVR2PGqqqga3 RBNAKTCLk18m6fy1aCkgJUriHC4Br0AtOieTzKtoq2N7PcBka1sfSi8LLyFUU/w+b6A6 JZmuQRxhom7rrHmoxkNnvNXVnUp1TogQlszyEjF/K6Lkr7EnUpMi3HOZ80v78mnKIaeE VtcW9ptQ83XitvjCAUe4LB4G2KQvkoU39Ww5BdMUpr84JMNjcm4gStsOsMcxtYyu75yx Hua1TEXEyX2C7P+AzlNzDA0njmcKZ89FJoB8khjZokXn8YeLtzB9vM0nW6TiuO6R8+bG wIUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694643543; x=1695248343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5pve2evvQG8Wu6dcM6eIRAvQq/3oe/203mcy+b19gA8=; b=pDUeKbSA+81ziHPnJ4Xyz5qhFhO93BKdX/haDbQlkSV2nzzAiVCdFG0wPWUtx5GhHW Xy1XhBA3DbE7Dndhe9l1iPSChRIDriOwZkE2oEPddXqGu37gkj61Jc674oEpRyjVyYh0 ufpVSpRbA/eqg9fhi0Xd85YCdFfiQ228gm3G2CFEsXe6oai66Ctw9tIln874BlK2f3O2 PqlZ+aFF6NxsdAcgOPU2nohF7rG/CFeEjPBYhRVfoYbtVZmkGxXPd8Z12ykZXLSa7RgP uT0v3e9J7OosqBem17xU3E6EA9/xyyE6lWU+dBAgCNK5qgMMEkAEdeT1RLSzTCYNjjjR wcQA== X-Gm-Message-State: AOJu0YxscNHJNk5ORrQCjUzR3l5NOm39RLKsfHvGyRYs/bzuQu6X3668 ZUQsVLEA/6Deyd36bUZR0rAmVM9vPhX8s2YdCuc3 X-Google-Smtp-Source: AGHT+IHd6f6RECjVcqmCL7A7894346dihNwE1aPIds0EMQzgoG2VHb2Uwc+wEHwTPX1DhNcQCvdHYBRnbGkUN+jxvow= X-Received: by 2002:a81:91d3:0:b0:59b:52c2:5f15 with SMTP id i202-20020a8191d3000000b0059b52c25f15mr19342ywg.25.1694643543316; Wed, 13 Sep 2023 15:19:03 -0700 (PDT) MIME-Version: 1.0 References: <202308240128.Gsn0b0Fv-lkp@intel.com> In-Reply-To: <202308240128.Gsn0b0Fv-lkp@intel.com> From: Paul Moore Date: Wed, 13 Sep 2023 18:18:52 -0400 Message-ID: Subject: Re: [PATCH] lsm: constify 'mnt_opts' parameter in security_free_mnt_opts() To: Khadija Kamran Cc: kernel test robot , Casey Schaufler , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , selinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, ztarkhani@microsoft.com, alison.schofield@intel.com, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: On Wed, Aug 23, 2023 at 1:22=E2=80=AFPM kernel test robot w= rote: > > Hi Khadija, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on pcmoore-selinux/next] > [also build test ERROR on pcmoore-audit/next linus/master v6.5-rc7 next-2= 0230823] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Khadija-Kamran/lsm= -constify-mnt_opts-parameter-in-security_free_mnt_opts/20230823-170310 > base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.g= it next > patch link: https://lore.kernel.org/r/ZOXG%2FVVC1XRc7TtI%40gmail.com > patch subject: [PATCH] lsm: constify 'mnt_opts' parameter in security_fre= e_mnt_opts() > config: riscv-randconfig-001-20230823 (https://download.01.org/0day-ci/ar= chive/20230824/202308240128.Gsn0b0Fv-lkp@intel.com/config) > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git = f28c006a5895fc0e329fe15fead81e37457cb1d1) > reproduce: (https://download.01.org/0day-ci/archive/20230824/202308240128= .Gsn0b0Fv-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202308240128.Gsn0b0Fv-lkp= @intel.com/ > > All errors (new ones prefixed by >>): > > >> fs/btrfs/super.c:1523:25: error: passing 'void **' to parameter of typ= e 'const void **' discards qualifiers in nested pointer types [-Werror,-Win= compatible-pointer-types-discards-qualifiers] > security_free_mnt_opts(&new_sec_opts); > ^~~~~~~~~~~~~ > include/linux/security.h:301:42: note: passing argument to parameter '= mnt_opts' here > void security_free_mnt_opts(const void **mnt_opts); > ^ > fs/btrfs/super.c:1536:25: error: passing 'void **' to parameter of typ= e 'const void **' discards qualifiers in nested pointer types [-Werror,-Win= compatible-pointer-types-discards-qualifiers] > security_free_mnt_opts(&new_sec_opts); > ^~~~~~~~~~~~~ > include/linux/security.h:301:42: note: passing argument to parameter '= mnt_opts' here > void security_free_mnt_opts(const void **mnt_opts); > ^ > fs/btrfs/super.c:1699:26: error: passing 'void **' to parameter of typ= e 'const void **' discards qualifiers in nested pointer types [-Werror,-Win= compatible-pointer-types-discards-qualifiers] > security_free_mnt_opts(&new_sec_opts); > ^~~~~~~~~~~~~ > include/linux/security.h:301:42: note: passing argument to parameter '= mnt_opts' here > void security_free_mnt_opts(const void **mnt_opts); > ^ > 3 errors generated. Hi Khadija, can you check to see if these errors can be resolved? --=20 paul-moore.com