From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC3B156674 for ; Tue, 9 Jul 2024 23:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720566828; cv=none; b=AROdqIR35YGzZsqtdy3iRzMwV9A4dWti4i6q2qNCMiUjYCLIAnrGI19w7mC2wHK0SgAYZhmV9rg9LJ9065mffskfThfMByxkXL3fPebuoNgP4c1bHhpw4KqIW0jOmLFxuxxtQUOMibJ/7/5wK42gmv9LP7uGcEQp/h7JjAh/Tf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720566828; c=relaxed/simple; bh=DDG3TE8Tj7wXuOW1XCEGC+yaI3BIS1r+9jx6G/XG4uM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Q341a4spLS8CKtLNjYPhnqycz+/9Lris0tN8vpziIrFcACfFnJQa04IjKEXP2qbd/GRRfm3r4a12cKRAPafnMRi5ZTw2Mz2vpQpEsQtZLA1Y6hTUvcUbvVn7GgpC12Lhqa/egFRkjypjkzAg4vkQccKWa0CBMxhy5j/XCOVhcas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=YTkbSOBR; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="YTkbSOBR" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-64d408a5d01so52780607b3.1 for ; Tue, 09 Jul 2024 16:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1720566826; x=1721171626; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r2M6TIe4a9DT8/78y438PlsE05xBzY4oBMJP1I0gw2M=; b=YTkbSOBRkyFJ9W/yDzRw/r1bNkD4BroYh+f/y/1Rjk9uwDMtBAgpL6UTRowF300ZDn 8HAhvPkDGBN1lQ/pKmqJnQBRUXxPOA+8mrlLpekVdqCJqABeadsKvJR4kxVy30bego52 HfSdSzF2KX0+i8GYgCmwBroHycX1LAwqwK9AuQBW/mO3Sw103qg0yDAqzrsi/ROGVGrB e63hWDoAFqEQeN4DS+7uYBt8RpH2gcApqB5gildXIw6ntsSdOd5d1eUUUbkK7gVradJM j/ygUENYl3P9JfSgt/lY6VblAkU/aF5u4I4q9y1wfhE4Ok/1R4tWB1PLijZBBxsw92sP QFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720566826; x=1721171626; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r2M6TIe4a9DT8/78y438PlsE05xBzY4oBMJP1I0gw2M=; b=fV9mb21awGH8osvD3J+8hlkpNPeDYAygPofraKqqLxqIac6QclhYDWzWfb7sAs6RaE BunqM2+BsoFyrDcX3/UwdJW5pYsXZfv9+wXWPSec1R2BNFkWz1Rn5J2RT+PAPVoqmYT5 1fBV/fICEWYmVf3AbGgEY7dAA1SrKcdNnq6K3qpLdl/axoMl/WDv87pbwqeFdq9MMWYn l2U959EOFiHJ2MdJSqIGCxM6tPybWOWay2efI9qL/oywLBse8qcfpPejmGmDmWlJX7uu iDiuXYP6MFcPtJtCASGJsQIYJzUv/8ABNx9/1qCD2Dk4VIdD794MUiwtrlHea5Oh0pD2 Kf/A== X-Forwarded-Encrypted: i=1; AJvYcCXYjqr8UH7ol+yihEMgFnK0sdz2AiT6WWvktQ1+seSE1KJOCJSPbZa5tR/OQZqOCtFFAdpScpLqG1kQ/m8DbKPM21nttJfxnhJg1PMMXAUggmd8DlEN X-Gm-Message-State: AOJu0YwDx4PBKSk6+EGYe4gf5QM7xGaGM77Y42xbCHLShZlKGB+lah3i YQ8n3TaB1UQ7t0bZ9sdGJ8+iNqGKZiiN84fk/o3LjnbJMdK/guKi698aDWBMTC5dr+4g8DxS3wA NzS+j2+V3nRx6nB8n5ksbHUOr8jKBXh41XWoW X-Google-Smtp-Source: AGHT+IFURzMl62B50V6bv7pkhDaaWMWC6GI/Yco9aDcZD0sGEVPUaa47A1Tw56Fqci4vHYAd8SZ0xzuprR9uFyD8iQE= X-Received: by 2002:a05:690c:728:b0:630:d0a3:d2e6 with SMTP id 00721157ae682-658f08ce64emr42146487b3.49.1720566825868; Tue, 09 Jul 2024 16:13:45 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <00000000000076ba3b0617f65cc8@google.com> <20240515.Yoo5chaiNai9@digikod.net> <20240516.doyox6Iengou@digikod.net> <20240627.Voox5yoogeum@digikod.net> <20240708.ig8Kucapheid@digikod.net> <20240709-bauaufsicht-bildschirm-331fb59cb6fb@brauner> In-Reply-To: <20240709-bauaufsicht-bildschirm-331fb59cb6fb@brauner> From: Paul Moore Date: Tue, 9 Jul 2024 19:13:35 -0400 Message-ID: Subject: Re: [syzbot] [lsm?] general protection fault in hook_inode_free_security To: =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= Cc: Christian Brauner , Al Viro , Jann Horn , "Paul E. McKenney" , Casey Schaufler , Kees Cook , syzbot , jmorris@namei.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, serge@hallyn.com, syzkaller-bugs@googlegroups.com, linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 9, 2024 at 1:47=E2=80=AFAM Christian Brauner wrote: > > > ... or we find a better placement in the VFS for > > > security_inode_free(), is that is possible. It may not be, our VFS > > > friends should be able to help here. > > The place where you do it currently is pretty good. I don't see an easy > way to call it from somewhere else without forcing every filesystem to > either implement a free_inode or destroy_inode hook. Micka=C3=ABl, let me play around with some code, if you don't see anything from me in a day or two, feel free to bug me :) --=20 paul-moore.com