From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659F5C27C76 for ; Fri, 20 Jan 2023 20:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230261AbjATUQm (ORCPT ); Fri, 20 Jan 2023 15:16:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbjATUQl (ORCPT ); Fri, 20 Jan 2023 15:16:41 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAD58A5007 for ; Fri, 20 Jan 2023 12:16:40 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id b17so6300941pld.7 for ; Fri, 20 Jan 2023 12:16:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RFrFWK6Yuz4He+Q+Dd7A5b23oGgMXF7yIM0sMxwjnok=; b=GEtp91po33uJf+p1P5Hc5s/2tlvFCr7HQo8fMdtWdFwOAKV/cTbo4kIAQnDjNlZDjU 14vOnNGtt87RBXe3J1jpz5oAeoA31b2snqnMZHdgwsEtFs1hzmAdRFMriSqk3OVzCQiN nZQVn75hMHzF/9+WXFXvcDX9dIl3pVF/+sJQTfiM+xfVJLlR6LS2ggokyEeCGRBm6Igk v1VzjEnio1hBX2if1z5QARkEPtO0eK7lA4d0OyvLyhSy8ifs6a+zrGeZeyB3ymBIZLTS LAMgOey1bNWRBY9DgftgDtvvBLiUKR7p7PX7twdgkAsiumDnsGuMJIsaBH5JVIqEwTh6 12Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RFrFWK6Yuz4He+Q+Dd7A5b23oGgMXF7yIM0sMxwjnok=; b=g4zvHkUwOfO7ntKZuEbz8U94YwpBwF5sACASMJWo+tFhWJjyTuIpBxDAuUpjDVNy5U 2XSD53dpybdgCAcjAdIZtuqoCkgTI+IfWxhQ1251X9eEc2QuSt61Z27dI8nqrJNbzGEC OwKZeurstbSP4h3hHKCO1696s/9sekKI9i9+4Q6n1heFtbpK5L736uKx8R8ZOzMLJ69n kms3bYQIcuJBojMLgFqMrT8qVyVlHqB4v0h9mSKhZYH3XRYKAocItkgsQ8+ybx7W1HfX hvJuS6IEvuVqaR9BxkacMyDhxNjOl2AnNr17Ap5+/urBDbAtWRUgfsx04ZAnXHEYgtdz l7zQ== X-Gm-Message-State: AFqh2koMcPWYz040SJx8OsBHeod+1jgaEJZJjUCH9J9i8mjFMez70NDX 3IPiFGlf5EzRbSJ6vrQyDhJObgdqo9vIXjRgis+s X-Google-Smtp-Source: AMrXdXuIJAna3jkn3HiysLFrRqrv7OboK2tJCEm7+hxOFIuo7F9HcZsXCZ1R/smMHmOl8DKk/3Z2TPkdG70lEMoVXF4= X-Received: by 2002:a17:902:b496:b0:172:86a2:8e68 with SMTP id y22-20020a170902b49600b0017286a28e68mr1610008plr.27.1674245800136; Fri, 20 Jan 2023 12:16:40 -0800 (PST) MIME-Version: 1.0 References: <20221207105430.248613-1-roberto.sassu@huaweicloud.com> In-Reply-To: From: Paul Moore Date: Fri, 20 Jan 2023 15:16:28 -0500 Message-ID: Subject: Re: [PATCH] public_key: Add a comment to public_key_signature struct definition To: Eric Biggers Cc: Roberto Sassu , dhowells@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Roberto Sassu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Fri, Jan 20, 2023 at 2:43 PM Eric Biggers wrote: > On Fri, Jan 20, 2023 at 02:21:04PM -0500, Paul Moore wrote: > > On Wed, Dec 7, 2022 at 5:55 AM Roberto Sassu > > wrote: > > > > > > From: Roberto Sassu > > > > > > public_key_verify_signature() calls sg_set_buf() to set the signature and > > > digest for the signature verification. > > > > > > As sg_set_buf() requires the buffer to be in physically contiguous memory, > > > see commit ac4e97abce9b8 ("scatterlist: sg_set_buf() argument must be in > > > linear mapping"), mention that in a comment for the signature and digest > > > fields of the public_key_signature structure. > > > > > > Link: https://lore.kernel.org/linux-integrity/Y4pIpxbjBdajymBJ@sol.localdomain/ > > > Suggested-by: Eric Biggers > > > Signed-off-by: Roberto Sassu > > > --- > > > include/crypto/public_key.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > This seems especially important considering the BUG_ON that could be triggered. > > > > David, are you going to pick this up? > > > > Reviewed-by: Paul Moore > > > > > diff --git a/include/crypto/public_key.h b/include/crypto/public_key.h > > > index 68f7aa2a7e55..6d623e063034 100644 > > > --- a/include/crypto/public_key.h > > > +++ b/include/crypto/public_key.h > > > @@ -37,8 +37,8 @@ extern void public_key_free(struct public_key *key); > > > */ > > > struct public_key_signature { > > > struct asymmetric_key_id *auth_ids[3]; > > > - u8 *s; /* Signature */ > > > - u8 *digest; > > > + u8 *s; /* Signature (in physically contiguous mem) */ > > > + u8 *digest; /* Digest (in physically contiguous mem) */ > > > u32 s_size; /* Number of bytes in signature */ > > > u32 digest_size; /* Number of bytes in digest */ > > > const char *pkey_algo; > > > -- > > > 2.25.1 > > This patch has been superseded by > "KEYS: asymmetric: Copy sig and digest in public_key_verify_signature()" > (https://lore.kernel.org/r/20221227142740.2807136-1-roberto.sassu@huaweicloud.com). Well nevermind then :) -- paul-moore.com