From: Paul Moore <paul@paul-moore.com>
To: "Christian Göttsche" <cgzones@googlemail.com>
Cc: linux-security-module@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] yama: document function parameter
Date: Tue, 26 Mar 2024 15:18:00 -0400 [thread overview]
Message-ID: <CAHC9VhTOmkpZu-zUEcvWJxLVHwoUnTcPxhBexs1ZKjr_LRKx_w@mail.gmail.com> (raw)
In-Reply-To: <20240315125418.273104-2-cgzones@googlemail.com>
On Fri, Mar 15, 2024 at 8:54 AM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Document the unused function parameter of yama_relation_cleanup() to
> please kernel doc warnings.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
> security/yama/yama_lsm.c | 1 +
> 1 file changed, 1 insertion(+)
One small comment below, but otherwise looks okay to me.
Reviewed-by:
> diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
> index 49dc52b454ef..f8e4acd41b72 100644
> --- a/security/yama/yama_lsm.c
> +++ b/security/yama/yama_lsm.c
> @@ -111,6 +111,7 @@ static void report_access(const char *access, struct task_struct *target,
>
> /**
> * yama_relation_cleanup - remove invalid entries from the relation list
> + * @work: unused
> *
> */
> static void yama_relation_cleanup(struct work_struct *work)
Should we also take this opportunity to mark the parameter as '__always_unused'?
--
paul-moore.com
next prev parent reply other threads:[~2024-03-26 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 12:54 [PATCH 2/2] apparmor: fix typo in kernel doc Christian Göttsche
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
2024-03-26 19:18 ` Paul Moore [this message]
2024-03-26 19:18 ` Paul Moore
2024-03-28 22:06 ` Kees Cook
2024-06-03 22:35 ` Paul Moore
2024-06-06 18:41 ` (subset) " Kees Cook
2024-03-28 22:06 ` [PATCH 2/2] apparmor: fix typo in kernel doc Kees Cook
2024-05-10 15:55 ` John Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhTOmkpZu-zUEcvWJxLVHwoUnTcPxhBexs1ZKjr_LRKx_w@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=cgzones@googlemail.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).