* [PATCH 2/2] apparmor: fix typo in kernel doc
@ 2024-03-15 12:54 Christian Göttsche
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Christian Göttsche @ 2024-03-15 12:54 UTC (permalink / raw)
To: linux-security-module
Cc: John Johansen, Paul Moore, James Morris, Serge E. Hallyn,
Kees Cook, apparmor, linux-kernel
Fix the typo in the function documentation to please kernel doc
warnings.
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
security/apparmor/lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index cef8c466af80..d0485fb0ed63 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -1124,7 +1124,7 @@ static int apparmor_socket_create(int family, int type, int protocol, int kern)
* @sock: socket that is being setup
* @family: family of socket being created
* @type: type of the socket
- * @ptotocol: protocol of the socket
+ * @protocol: protocol of the socket
* @kern: socket is a special kernel socket
*
* Note:
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 1/2] yama: document function parameter
2024-03-15 12:54 [PATCH 2/2] apparmor: fix typo in kernel doc Christian Göttsche
@ 2024-03-15 12:54 ` Christian Göttsche
2024-03-26 19:18 ` Paul Moore
` (2 more replies)
2024-03-28 22:06 ` [PATCH 2/2] apparmor: fix typo in kernel doc Kees Cook
2024-05-10 15:55 ` John Johansen
2 siblings, 3 replies; 9+ messages in thread
From: Christian Göttsche @ 2024-03-15 12:54 UTC (permalink / raw)
To: linux-security-module
Cc: Kees Cook, Paul Moore, James Morris, Serge E. Hallyn,
linux-kernel
Document the unused function parameter of yama_relation_cleanup() to
please kernel doc warnings.
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
security/yama/yama_lsm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
index 49dc52b454ef..f8e4acd41b72 100644
--- a/security/yama/yama_lsm.c
+++ b/security/yama/yama_lsm.c
@@ -111,6 +111,7 @@ static void report_access(const char *access, struct task_struct *target,
/**
* yama_relation_cleanup - remove invalid entries from the relation list
+ * @work: unused
*
*/
static void yama_relation_cleanup(struct work_struct *work)
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] yama: document function parameter
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
@ 2024-03-26 19:18 ` Paul Moore
2024-03-26 19:18 ` Paul Moore
2024-03-28 22:06 ` Kees Cook
2024-06-06 18:41 ` (subset) " Kees Cook
2 siblings, 1 reply; 9+ messages in thread
From: Paul Moore @ 2024-03-26 19:18 UTC (permalink / raw)
To: Christian Göttsche
Cc: linux-security-module, Kees Cook, James Morris, Serge E. Hallyn,
linux-kernel
On Fri, Mar 15, 2024 at 8:54 AM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Document the unused function parameter of yama_relation_cleanup() to
> please kernel doc warnings.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
> security/yama/yama_lsm.c | 1 +
> 1 file changed, 1 insertion(+)
One small comment below, but otherwise looks okay to me.
Reviewed-by:
> diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
> index 49dc52b454ef..f8e4acd41b72 100644
> --- a/security/yama/yama_lsm.c
> +++ b/security/yama/yama_lsm.c
> @@ -111,6 +111,7 @@ static void report_access(const char *access, struct task_struct *target,
>
> /**
> * yama_relation_cleanup - remove invalid entries from the relation list
> + * @work: unused
> *
> */
> static void yama_relation_cleanup(struct work_struct *work)
Should we also take this opportunity to mark the parameter as '__always_unused'?
--
paul-moore.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] yama: document function parameter
2024-03-26 19:18 ` Paul Moore
@ 2024-03-26 19:18 ` Paul Moore
0 siblings, 0 replies; 9+ messages in thread
From: Paul Moore @ 2024-03-26 19:18 UTC (permalink / raw)
To: Christian Göttsche
Cc: linux-security-module, Kees Cook, James Morris, Serge E. Hallyn,
linux-kernel
On Tue, Mar 26, 2024 at 3:18 PM Paul Moore <paul@paul-moore.com> wrote:
>
> On Fri, Mar 15, 2024 at 8:54 AM Christian Göttsche
> <cgzones@googlemail.com> wrote:
> >
> > Document the unused function parameter of yama_relation_cleanup() to
> > please kernel doc warnings.
> >
> > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> > ---
> > security/yama/yama_lsm.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> One small comment below, but otherwise looks okay to me.
>
> Reviewed-by:
Bah, let's try that again ...
Reviewed-by: Paul Moore <paul@paul-moore.com>
> > diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
> > index 49dc52b454ef..f8e4acd41b72 100644
> > --- a/security/yama/yama_lsm.c
> > +++ b/security/yama/yama_lsm.c
> > @@ -111,6 +111,7 @@ static void report_access(const char *access, struct task_struct *target,
> >
> > /**
> > * yama_relation_cleanup - remove invalid entries from the relation list
> > + * @work: unused
> > *
> > */
> > static void yama_relation_cleanup(struct work_struct *work)
>
> Should we also take this opportunity to mark the parameter as '__always_unused'?
--
paul-moore.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] yama: document function parameter
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
2024-03-26 19:18 ` Paul Moore
@ 2024-03-28 22:06 ` Kees Cook
2024-06-03 22:35 ` Paul Moore
2024-06-06 18:41 ` (subset) " Kees Cook
2 siblings, 1 reply; 9+ messages in thread
From: Kees Cook @ 2024-03-28 22:06 UTC (permalink / raw)
To: Christian Göttsche
Cc: linux-security-module, Paul Moore, James Morris, Serge E. Hallyn,
linux-kernel
On Fri, Mar 15, 2024 at 01:54:10PM +0100, Christian Göttsche wrote:
> Document the unused function parameter of yama_relation_cleanup() to
> please kernel doc warnings.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] yama: document function parameter
2024-03-28 22:06 ` Kees Cook
@ 2024-06-03 22:35 ` Paul Moore
0 siblings, 0 replies; 9+ messages in thread
From: Paul Moore @ 2024-06-03 22:35 UTC (permalink / raw)
To: Kees Cook
Cc: Christian Göttsche, linux-security-module, James Morris,
Serge E. Hallyn, linux-kernel
On Thu, Mar 28, 2024 at 6:06 PM Kees Cook <keescook@chromium.org> wrote:
> On Fri, Mar 15, 2024 at 01:54:10PM +0100, Christian Göttsche wrote:
> > Document the unused function parameter of yama_relation_cleanup() to
> > please kernel doc warnings.
> >
> > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
I ran across this in patchwork just now and don't see it upstream yet,
you're picking this up right Kees?
--
paul-moore.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 1/2] yama: document function parameter
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
2024-03-26 19:18 ` Paul Moore
2024-03-28 22:06 ` Kees Cook
@ 2024-06-06 18:41 ` Kees Cook
2 siblings, 0 replies; 9+ messages in thread
From: Kees Cook @ 2024-06-06 18:41 UTC (permalink / raw)
To: linux-security-module, Christian Göttsche
Cc: Kees Cook, Paul Moore, James Morris, Serge E. Hallyn,
linux-kernel
On Fri, 15 Mar 2024 13:54:10 +0100, Christian Göttsche wrote:
> Document the unused function parameter of yama_relation_cleanup() to
> please kernel doc warnings.
>
>
Applied to for-next/hardening, thanks!
[1/2] yama: document function parameter
https://git.kernel.org/kees/c/f7d3b1ffc654
Take care,
--
Kees Cook
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] apparmor: fix typo in kernel doc
2024-03-15 12:54 [PATCH 2/2] apparmor: fix typo in kernel doc Christian Göttsche
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
@ 2024-03-28 22:06 ` Kees Cook
2024-05-10 15:55 ` John Johansen
2 siblings, 0 replies; 9+ messages in thread
From: Kees Cook @ 2024-03-28 22:06 UTC (permalink / raw)
To: Christian Göttsche
Cc: linux-security-module, John Johansen, Paul Moore, James Morris,
Serge E. Hallyn, apparmor, linux-kernel
On Fri, Mar 15, 2024 at 01:54:09PM +0100, Christian Göttsche wrote:
> Fix the typo in the function documentation to please kernel doc
> warnings.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] apparmor: fix typo in kernel doc
2024-03-15 12:54 [PATCH 2/2] apparmor: fix typo in kernel doc Christian Göttsche
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
2024-03-28 22:06 ` [PATCH 2/2] apparmor: fix typo in kernel doc Kees Cook
@ 2024-05-10 15:55 ` John Johansen
2 siblings, 0 replies; 9+ messages in thread
From: John Johansen @ 2024-05-10 15:55 UTC (permalink / raw)
To: Christian Göttsche, linux-security-module
Cc: Paul Moore, James Morris, Serge E. Hallyn, Kees Cook, apparmor,
linux-kernel
On 3/15/24 05:54, Christian Göttsche wrote:
> Fix the typo in the function documentation to please kernel doc
> warnings.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Acked-by: John Johansen <john.johansen@canonical.com>
I have pulled this into my tree
> ---
> security/apparmor/lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index cef8c466af80..d0485fb0ed63 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -1124,7 +1124,7 @@ static int apparmor_socket_create(int family, int type, int protocol, int kern)
> * @sock: socket that is being setup
> * @family: family of socket being created
> * @type: type of the socket
> - * @ptotocol: protocol of the socket
> + * @protocol: protocol of the socket
> * @kern: socket is a special kernel socket
> *
> * Note:
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-06-06 18:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-15 12:54 [PATCH 2/2] apparmor: fix typo in kernel doc Christian Göttsche
2024-03-15 12:54 ` [PATCH 1/2] yama: document function parameter Christian Göttsche
2024-03-26 19:18 ` Paul Moore
2024-03-26 19:18 ` Paul Moore
2024-03-28 22:06 ` Kees Cook
2024-06-03 22:35 ` Paul Moore
2024-06-06 18:41 ` (subset) " Kees Cook
2024-03-28 22:06 ` [PATCH 2/2] apparmor: fix typo in kernel doc Kees Cook
2024-05-10 15:55 ` John Johansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).