From: Shu Han <ebpqwerty472123@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: syzbot <syzbot+1cd571a672400ef3a930@syzkaller.appspotmail.com>,
akpm@linux-foundation.org, dmitry.kasatkin@gmail.com,
eric.snowberg@oracle.com, hughd@google.com, jmorris@namei.org,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-security-module@vger.kernel.org,
roberto.sassu@huawei.com, serge@hallyn.com,
stephen.smalley.work@gmail.com, syzkaller-bugs@googlegroups.com,
zohar@linux.ibm.com
Subject: Re: [syzbot] [integrity?] [lsm?] possible deadlock in process_measurement (4)
Date: Thu, 3 Oct 2024 15:35:51 +0800 [thread overview]
Message-ID: <CAHQche-HPzahcHea65f-caRBUSvr4WsRF5J8cqYGnjJvBNTX5g@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhSHSD5QF8w2+n9f1DAEfQAwW5eA0skSuap2jdMWrLfGWQ@mail.gmail.com>
> My apologies for the delay on this, I was traveling for a bit and
> missed this issue while away.
>
> Looking quickly at the report, I don't believe this is a false positive.
This is the mistake I made when I first watched the report.
It should be a deadlock.
> Looking at the IMA code, specifically the process_measurement()
> function which is called from the security_mmap_file() LSM hook, I'm
> not sure why there is the inode_lock() protected region. Mimi?
> Roberto? My best guess is that locking the inode may have been
> necessary before we moved the IMA inode state into the inode's LSM
> security blob, but I'm not certain.
>
> Mimi and Roberto, can we safely remove the inode locking in
> process_measurement()?
It would be better if IMA could avoid acqurie inode_lock().
If not, then we may need to consider solutions I mentioned in my
previous reply.
next prev parent reply other threads:[~2024-10-03 7:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 7:32 [syzbot] [integrity?] [lsm?] possible deadlock in process_measurement (4) syzbot
2024-09-28 13:56 ` Andrew Morton
2024-09-28 18:07 ` Shu Han
2024-10-03 3:09 ` Paul Moore
2024-10-03 7:35 ` Shu Han [this message]
2024-10-07 15:31 ` Roberto Sassu
2024-10-07 16:35 ` Paul Moore
2024-10-07 16:49 ` Roberto Sassu
2024-10-07 16:58 ` Paul Moore
2024-10-09 16:23 ` Roberto Sassu
2024-10-09 19:05 ` syzbot
2024-10-18 14:55 ` Roberto Sassu
2024-10-18 15:23 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQche-HPzahcHea65f-caRBUSvr4WsRF5J8cqYGnjJvBNTX5g@mail.gmail.com \
--to=ebpqwerty472123@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=hughd@google.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=syzbot+1cd571a672400ef3a930@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).