From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C4D1C7EE2F for ; Fri, 9 Jun 2023 16:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229737AbjFIQqI (ORCPT ); Fri, 9 Jun 2023 12:46:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbjFIQpx (ORCPT ); Fri, 9 Jun 2023 12:45:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9641F3A97 for ; Fri, 9 Jun 2023 09:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686329097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lP5O6Y+WWlbHJraaUNqLEu0298uTs2XTBNqgvHhDjHo=; b=GTQQd7l1Wz1r48CRd5HA1lJ3vVn9oh3zOYme4Yj4Iy1cbL3Dx8ihREKZEQBaBUJfcsMXD2 PVdtxVk7r+5eI1BxdY93iYvBoERwo79GpCxynjsMhaM5u8VZh0PZmgcJS6hirqz+SpkFmn 6FSVGcSLPVeNVLEWRhVCSP0r+d8864E= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-237-hbhaU2wEMHqddy75tkE5TQ-1; Fri, 09 Jun 2023 12:44:54 -0400 X-MC-Unique: hbhaU2wEMHqddy75tkE5TQ-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-1b03cfa7602so6733175ad.3 for ; Fri, 09 Jun 2023 09:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686329093; x=1688921093; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lP5O6Y+WWlbHJraaUNqLEu0298uTs2XTBNqgvHhDjHo=; b=OrPv4atTrBh1CigvmAl5KugG+IxO4W1Lp418bp7O7nDbmAX7ut6btsFHIBsy0VdRje jILj53CTHU0qnuv73N9TDMIWoi7tQBw6He58rGeDKQpqtSv3xXZHN/XHzhpwe6H0ZKKx dtA/nRtp11Ez5+4G+kQklQWhTfweCTljHwt3ef3LuNxxz9QiVgVEUls1f8LYFZ/u3IrJ kxTl+23K68Gm3vdvtKFjW2lcyTpmFlU57N1Gh6mlNAU7b52G1w/gVizui2TU/qKvom6+ SVVpcTVUJ8ct37Oq53QVeozpI9KCgXYCmLalPRHicU6Kxvii9WjTzASoZ9lRCB0A0JNg ZRiA== X-Gm-Message-State: AC+VfDzsaqbFFB7BETGjr2iU8ZjB9TyfRfOpRJlyrziYOsDMSBe8UnyB CBUHs8ciu3vzXw7uQwq+d7gMfGLCDxiXt7JcXAMAiHxdVJ/N0NBJ2bK1MWycSBlXS9+1K7U0JgR +tjB5gh6AK7mymcuIL7HnlFcTXPDvFzbAAr37YQBoLhavwq80Gd0r X-Received: by 2002:a17:902:b905:b0:1af:e63f:5bb1 with SMTP id bf5-20020a170902b90500b001afe63f5bb1mr1282655plb.7.1686329092972; Fri, 09 Jun 2023 09:44:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7zDVq695OK7McLR4vzNBftl0R3SL21TRjXzZOuBBU36wjdeP/MVpNAkO6JcixIuhfY6AAHiytBnKwzWzUI7o8= X-Received: by 2002:a17:902:b905:b0:1af:e63f:5bb1 with SMTP id bf5-20020a170902b90500b001afe63f5bb1mr1282622plb.7.1686329092671; Fri, 09 Jun 2023 09:44:52 -0700 (PDT) MIME-Version: 1.0 References: <20230609125023.399942-1-jlayton@kernel.org> <20230609125023.399942-8-jlayton@kernel.org> In-Reply-To: <20230609125023.399942-8-jlayton@kernel.org> From: Andreas Gruenbacher Date: Fri, 9 Jun 2023 18:44:41 +0200 Message-ID: Subject: Re: [PATCH 7/9] gfs2: update ctime when quota is updated To: Jeff Layton Cc: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Bob Peterson , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Suren Baghdasaryan , Sebastian Reichel , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: Jeff, On Fri, Jun 9, 2023 at 2:50=E2=80=AFPM Jeff Layton wro= te: > Signed-off-by: Jeff Layton > --- > fs/gfs2/quota.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c > index 1ed17226d9ed..6d283e071b90 100644 > --- a/fs/gfs2/quota.c > +++ b/fs/gfs2/quota.c > @@ -869,7 +869,7 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, l= off_t loc, > size =3D loc + sizeof(struct gfs2_quota); > if (size > inode->i_size) > i_size_write(inode, size); > - inode->i_mtime =3D inode->i_atime =3D current_time(inode)= ; > + inode->i_mtime =3D inode->i_atime =3D inode->i_ctime =3D = current_time(inode); I don't think we need to worry about the ctime of the quota inode as that inode is internal to the filesystem only. > mark_inode_dirty(inode); > set_bit(QDF_REFRESH, &qd->qd_flags); > } > -- > 2.40.1 > Thanks, Andreas