From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75291266A7 for ; Tue, 4 Jun 2024 18:48:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717526937; cv=none; b=GP95MLyX3wgfNwfFfrFxtry9Y4+P5vJshDVzD2kiHG8jWJ35WPLCMnX8XVBtRXV/diANW8Lqk80+Vh3F2u+8bO7rn5yJoHogbhHdIXWNsk1RW/po1v+MbBsY8Y6pqXcy6cc9kjFHsowGM7BzBkbeNUmeapkoo5hf0RzqxbMF88k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717526937; c=relaxed/simple; bh=grQASJp14Bt7fZYtPF/BOiWWydFpPjbo/cl/eIyN7Yw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SR8MnB9S9twa4A1ghiqCZPfqQZq3BhECP+7/uCAegIZVzP7HRSAW4jKx2mWN/009AWyU/oizWsHdpdouuTXVOV6/3bGmtUbZp9u4lmiZcoxtDPLS3FGvAPnqPFBU+5fHcb51mnWMNmV1wksXq4DEeBxNbFHFylooMtkLUkZUEC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=WlYnONU7; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WlYnONU7" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-57a23997da3so6551038a12.3 for ; Tue, 04 Jun 2024 11:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1717526933; x=1718131733; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3Iay1wNfKZ5p2yKYQUB8UE9csohQVR6x64V5CAu9ZDo=; b=WlYnONU7rlWIPHppfvKYeatgnMFn2CRZv6F93PiDnt0WXlLkDuG4BCpU0IbmcwkZY8 4goiwA0XTV2wmlMMXrgW58COueGVHjAMLQCfw0NSNvto17rHacMC7QjNvAYwu1r75C5S Bbm32EPWipyG8oOhuqr7H9ym//o+Z4eMkT9Kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717526933; x=1718131733; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Iay1wNfKZ5p2yKYQUB8UE9csohQVR6x64V5CAu9ZDo=; b=Pyd61IFtV4WRaNDFO79un7FsfOQoTULar0xGqTo9jspUoty+hKcJ/NTeASUnVQtE/D E7WcbHH59eObcO5zMbJDe6Zfd7FEysX83kIzmoBZJwEk8V+hySUCEpFEANyMGcaKCYTQ bg1TPVemOJKISQBZzdE2ZDCHKwGoZ8g3Gwdb745xX7DA+sSMk9b+ya6E9lL5FOXeti83 JFnKyZGZ1aL7UEYoyyTt1rvSg2cOajkm1z4nEgW5FrytIqvftB923sNZGD3TeiSznG8g pIdK8dSjdUgbq9hp78Po96mhJfF2kC7i6Vui49IFD7pTlWJrgHUyuOLi8ue95hZYPniC 91hA== X-Forwarded-Encrypted: i=1; AJvYcCVDQHzHbLlwrspni5d61PMEaacBXWQDVsNvQIx5jJNrzFQb42f3OOpm3CCKKP5yd/vpr5Faz0AWMjTJ2FONQq+BEGPkxjXIWUE+pZqROg2j2zkr6RdT X-Gm-Message-State: AOJu0Yy63zT7M4SWYdWVasIyB2ojChL8pnaC8i88Wm6xtJocPjt5dPMl FpjMwIjzweiBQCq6RKzeBADsjMflXCnEnAJmcvYk6jYugrBBLevIGJ7K4+HBUC/a2AqNlMdfNje 0G7LAvgJe X-Google-Smtp-Source: AGHT+IHzsYQwPPeqfJGR7WvBjpNOF62IcDkRzMneA0jExYeBqvqhmdQNS4IYG1G7hIrL12q3JK5rFA== X-Received: by 2002:a50:d4d2:0:b0:57a:2430:67eb with SMTP id 4fb4d7f45d1cf-57a8bc9506dmr278789a12.28.1717526933678; Tue, 04 Jun 2024 11:48:53 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a31bb8219sm7714322a12.22.2024.06.04.11.48.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 11:48:53 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-35dc9cef36dso5019887f8f.3 for ; Tue, 04 Jun 2024 11:48:53 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUtFwWmf9mgvmm5nI1GyXGYANBMrH6FY728RJhmD253EW8mZ+O9I1PlsmsG6jUjxhd5W1/tEUC4dGVKReG9SUsEz1AQfPIWmh/wNYiVX7C1mk0nhQr4 X-Received: by 2002:a17:906:54b:b0:a62:2cae:c02 with SMTP id a640c23a62f3a-a69a024ce40mr20818866b.61.1717526574326; Tue, 04 Jun 2024 11:42:54 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> In-Reply-To: From: Linus Torvalds Date: Tue, 4 Jun 2024 11:42:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string() To: Rodrigo Vivi Cc: Andy Shevchenko , "Rafael J. Wysocki" , Greg Kroah-Hartman , Corey Minyard , Allen Pais , Sebastian Reichel , Perry Yuan , Giovanni Cabiddu , Herbert Xu , Nuno Sa , Guenter Roeck , Randy Dunlap , Andi Shyti , Heiner Kallweit , Lee Jones , Samuel Holland , Elad Nachman , Arseniy Krasnov , Johannes Berg , Gregory Greenman , Benjamin Berg , Bjorn Helgaas , Robert Richter , Vinod Koul , Chunfeng Yun , Linus Walleij , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Nikita Kravets , Jiri Slaby , Srinivas Pandruvada , Stanley Chang , Heikki Krogerus , Abdel Alkuor , Kent Overstreet , Eric Biggers , Kees Cook , Ingo Molnar , "Steven Rostedt (Google)" , Daniel Bristot de Oliveira , Andrew Morton , Hugh Dickins , Abel Wu , John Johansen , Mimi Zohar , Stefan Berger , Roberto Sassu , Eric Snowberg , Takashi Iwai , Takashi Sakamoto , Jiapeng Chong , Mark Brown , Kuninori Morimoto , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, linux-ide@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, qat-linux@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-leds@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-hardening@vger.kernel.org, cgroups@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Howells , "David S. Miller" , "Rafael J. Wysocki" , Len Brown , Sergey Shtylyov , Damien Le Moal , Niklas Cassel , Daniel Scally , Sakari Ailus , Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Heiko Stuebner , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Viresh Kumar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Karol Herbst , Lyude Paul , Danilo Krummrich , Jean Delvare , Alexander Shishkin , Pavel Machek , Chen-Yu Tsai , Jernej Skrabec , Tony Lindgren , Adrian Hunter , Hu Ziji , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Potnuri Bharat Teja , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Miri Korenblit , Kalle Valo , Mahesh J Salgaonkar , "Oliver O'Halloran" , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , JC Kuo , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Sebastian Reichel , Daniel Lezcano , Zhang Rui , Lukasz Luba , Thinh Nguyen , Helge Deller , Brian Foster , Zhihao Cheng , Tejun Heo , Zefan Li , Johannes Weiner , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Masami Hiramatsu , Mathieu Desnoyers , Jason Baron , Jim Cromie , Paul Moore , James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Liam Girdwood Content-Type: text/plain; charset="UTF-8" On Tue, 4 Jun 2024 at 11:25, Rodrigo Vivi wrote: > > (I believe that the new _match_string(str1, size, str2) deserves a better name, > but since I'm bad with naming stuff, I don't have any good suggestion) I hated the enormous cc list, so I didn't reply to all. But clearly everybody else is just doing so. Anyway, here's my NAK for this patch with explanation: https://lore.kernel.org/all/CAHk-=wg5F99-GZPETsasJd0JB0JGcdmmPeHRxCtT4_i83h8avg@mail.gmail.com/ and part of it was the naming, but there were other oddities there too. Linus