From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A62EC433DF for ; Mon, 3 Aug 2020 16:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25FE8207FB for ; Mon, 3 Aug 2020 16:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="hXoXZ6TB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbgHCQmz (ORCPT ); Mon, 3 Aug 2020 12:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726983AbgHCQmx (ORCPT ); Mon, 3 Aug 2020 12:42:53 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93352C061756 for ; Mon, 3 Aug 2020 09:42:53 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id df16so11364420edb.9 for ; Mon, 03 Aug 2020 09:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0pKh21HmMgiXpI5XylfnfnlKkDhj9u5DS7LTshm78/Q=; b=hXoXZ6TBCbBScXYbb5A1s7OlEyuW5Wtgf1zZ0XwdDpBSIHsqy8yvn5+w2rGc69nZIT l14JxxWwHcaySE3rw7efhnidZfyYOHa92F+dTJ+xiUKYry90lsnY3Oy+qndo0W7azWJp HxqF9785aLkrsVVsbqgHaqnHqSXxXIEZw0afc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0pKh21HmMgiXpI5XylfnfnlKkDhj9u5DS7LTshm78/Q=; b=aXvADGbLyFsp+e1IXXt5nm8gQhnErj/NBKBPPoXS/DEHxjijs1jAN5wdqOPgrOS+Y8 2/A5YIgIMHpec6BdhWpmj4cRFRV8vBk2RSiPY/k7Ud+sIxz8Q71ss3jGa734jQQR6vaN 2NzdDOZqSwKqjtPuNtnVGDxV0CFk9qHx0W5WeLPCgQu3EsEo8TQHTCn7m1zhusKqtvu5 r+5vjuNsjeY8R1cNdyjqYzBGoIyPolK1uGjqhRHrtdr2cIzLjdMUxXRLwS6hGv2X4prN OilLeIDfpo4PbDNbPgKInNQj8BVB79MNg1m3qeY9QektT3YdSQ8ICFmbNpsn/QEMLVxj hY8w== X-Gm-Message-State: AOAM530pvfplUNTQLEJ7snlTa7zMvLEGGVkZM2SXeUAMSUG6kk8KrvOx 7dkX0pTv1OHPwP5NHEK3QxwBYxSTS0HKeEOMG8I1OA== X-Google-Smtp-Source: ABdhPJwGt6JJkCjQ+xGlIzKcZ+W4kFA471qhTIr1uxHZ9OOmk1ZAH30Hdlmr+9NCbPwUEszgoyIELLGeaKMDR31yuwI= X-Received: by 2002:aa7:c915:: with SMTP id b21mr17121686edt.17.1596472972292; Mon, 03 Aug 2020 09:42:52 -0700 (PDT) MIME-Version: 1.0 References: <1842689.1596468469@warthog.procyon.org.uk> <1845353.1596469795@warthog.procyon.org.uk> In-Reply-To: <1845353.1596469795@warthog.procyon.org.uk> From: Miklos Szeredi Date: Mon, 3 Aug 2020 18:42:41 +0200 Message-ID: Subject: Re: [GIT PULL] Filesystem Information To: David Howells Cc: Linus Torvalds , Al Viro , Ian Kent , Karel Zak , Jeff Layton , Miklos Szeredi , Nicolas Dichtel , Christian Brauner , Lennart Poettering , Linux API , linux-fsdevel@vger.kernel.org, LSM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Aug 3, 2020 at 5:50 PM David Howells wrote: > > > Hi Linus, > > Here's a set of patches that adds a system call, fsinfo(), that allows > information about the VFS, mount topology, superblock and files to be > retrieved. > > The patchset is based on top of the mount notifications patchset so that > the mount notification mechanism can be hooked to provide event counters > that can be retrieved with fsinfo(), thereby making it a lot faster to wo= rk > out which mounts have changed. > > Note that there was a last minute change requested by Mikl=C3=B3s: the ev= ent > counter bits got moved from the mount notification patchset to this one. > The counters got made atomic_long_t inside the kernel and __u64 in the > UAPI. The aggregate changes can be assessed by comparing pre-change tag, > fsinfo-core-20200724 to the requested pull tag. > > Karel Zak has created preliminary patches that add support to libmount[*] > and Ian Kent has started working on making systemd use these and mount > notifications[**]. So why are you asking to pull at this stage? Has anyone done a review of the patchset? I think it's obvious that this API needs more work. The integration work done by Ian is a good direction, but it's not quite the full validation and review that a complex new API needs. At least that's my opinion. Thanks, Miklos