From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 002A122E3E9 for ; Thu, 6 Nov 2025 01:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762394177; cv=none; b=MMp32u2phlKCjnfv35QcgS85eVoDgvmYHwxbKKsCZAN5upe3JsAA0J+WxOY8YZjdaDSDnqiXJPAO7HeVpKqA8faSu/C0Fr2l+hw6+d84Bn26DhtJFn1wZWba9gsl6hPheR/yW2aF+V3zCOAz8l9eR0YzgXIhjRfrjW7A20YX07I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762394177; c=relaxed/simple; bh=Lwi+HBW6NI9Zzpj1VH4WGk4UsyyneW2Nkp2PQ1aZCJk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Y77pCON2zAAEACEo3rKxrtJccGT0UO/ix5BDkjWuxlAlNs5YG9EgFLwXFqX8B5l5/vvk8GZJ9qtvFYrm18decsT2vRuK5bYfnkN9JQPbi0At9M832BVo8USLsU4VfYsdcItBFO0BgPNxex8K/A0dqtaXD8ydZ+O+lwGvLABHs0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jFAezk7b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jFAezk7b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B492AC19424 for ; Thu, 6 Nov 2025 01:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762394176; bh=Lwi+HBW6NI9Zzpj1VH4WGk4UsyyneW2Nkp2PQ1aZCJk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jFAezk7bFkzOnpSyKtu/v/0eMNhdxWRoH1Mwm+NPQd0YUkK/tMK3Xje0KPEp81c7F XsYqd64+4G4K6CK9dfdMN/Z1hEHdawN/kdcYTQpiQJNwk3yQk9hwx698TPLcTPbwHG 9d1vTFv8sBziGLxYtWQkJlP8ajLZZPGjPgJwGOEblng3QHZLv+j2LuQ7XwG0n4UzUa TeLk3tNQzrVyW2ycOtHn/XQuZy0wN+sNSPL/5bTh4MhmvKJf/kjYvRSb0HQxZv2cu0 WKGGnfm/9o/+LHPHYI4upH6AjvoBfTgVVnEcnXfaY3ZSsDJpK48OI5cAmZcxGbRqbW EJvb0sm9iPvDA== Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6409e985505so631295a12.2 for ; Wed, 05 Nov 2025 17:56:16 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXmOiQOJPuO2attpDQ9DcYhG2C/mwRmy1tfymg/nV57JVYyT06QPCl820qysnwGJmWmNiePBFknAuDzULktmF0c+P+PVnY=@vger.kernel.org X-Gm-Message-State: AOJu0YxLR92DodZbCxO01Nfszy/KcNDkW0L46jXs/sh3JPtaVzgQks2z mWVdLBxL4qeBMoKQlLt2NidsNah4KKWR3626krM5lkDWPmsYBfVp4AcM81rLrYow1Grrq+I1vgP kAFIDdN7lfLVX1K906swolqNOEtO/DrI= X-Google-Smtp-Source: AGHT+IGRWQr/yMix2KC9FWBoMcuBXJI8axGaVe0Q7R1p9lozVUkvmiwrl4KtXQgDBkKGB2LM0O8foBaqARcRluikU3E= X-Received: by 2002:a05:6402:51d1:b0:63c:2d72:56e3 with SMTP id 4fb4d7f45d1cf-64105a5d549mr4682456a12.23.1762394174672; Wed, 05 Nov 2025 17:56:14 -0800 (PST) Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251106005333.956321-1-neilb@ownmail.net> <20251106005333.956321-8-neilb@ownmail.net> In-Reply-To: <20251106005333.956321-8-neilb@ownmail.net> From: Namjae Jeon Date: Thu, 6 Nov 2025 10:56:01 +0900 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_blmBmQhx0SfF_RJrLZwQ93tMKfLranVnNF6NMqPQEMSGUPWm6n05JxFEa0 Message-ID: Subject: Re: [PATCH v5 07/14] VFS: introduce start_removing_dentry() To: NeilBrown Cc: Alexander Viro , Christian Brauner , Amir Goldstein , Jan Kara , linux-fsdevel@vger.kernel.org, Jeff Layton , Chris Mason , David Sterba , David Howells , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Tyler Hicks , Miklos Szeredi , Chuck Lever , Olga Kornievskaia , Dai Ngo , Steve French , Sergey Senozhatsky , Carlos Maiolino , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Ondrej Mosnacek , Mateusz Guzik , Lorenzo Stoakes , Stefan Berger , "Darrick J. Wong" , linux-kernel@vger.kernel.org, netfs@lists.linux.dev, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Nov 6, 2025 at 9:55=E2=80=AFAM NeilBrown wrote: > > From: NeilBrown > > start_removing_dentry() is similar to start_removing() but instead of > providing a name for lookup, the target dentry is given. > > start_removing_dentry() checks that the dentry is still hashed and in > the parent, and if so it locks and increases the refcount so that > end_removing() can be used to finish the operation. > > This is used in cachefiles, overlayfs, smb/server, and apparmor. > > There will be other users including ecryptfs. > > As start_removing_dentry() takes an extra reference to the dentry (to be > put by end_removing()), there is no need to explicitly take an extra > reference to stop d_delete() from using dentry_unlink_inode() to negate > the dentry - as in cachefiles_delete_object(), and ksmbd_vfs_unlink(). > > cachefiles_bury_object() now gets an extra ref to the victim, which is > drops. As it includes the needed end_removing() calls, the caller > doesn't need them. > > Reviewed-by: Amir Goldstein > Signed-off-by: NeilBrown For ksmbd part, Reviewed-by: Namjae Jeon Thanks!