From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 176D9C46460 for ; Mon, 3 Jun 2019 21:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E43FD206BA for ; Mon, 3 Jun 2019 21:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559598447; bh=n9SyFEz1scq0F+hulkDOofWavK0RVDUzt5KbFhVJxXU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=AIZfaUFCBzR8Sv50n0y/esI8/6b1pQABmTth5ZwPZfE3bjoBDk6HM1M4GrvYrP679 o8P8XKQsMJSO5kyi/Qt06gICsdw0RdXJJEfwmiUDe0qoWrRg1K+D6FJl1nj7Igq+AD 6DZGCbMN8wnA6yqab9mJpnQf9R/BrHUryOIu2Suk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbfFCVr0 (ORCPT ); Mon, 3 Jun 2019 17:47:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:36780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfFCVrZ (ORCPT ); Mon, 3 Jun 2019 17:47:25 -0400 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F05A24700 for ; Mon, 3 Jun 2019 21:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559597851; bh=n9SyFEz1scq0F+hulkDOofWavK0RVDUzt5KbFhVJxXU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Wl+zxf1zXrXTscPd69no8f3com+w7DM1Ij9JSl6nzJEwn21nR1/vkX/KVRgO+NKi5 HqAYbd2/RvghdNstiyg9ha1DYR41NNpT/hot0tEZcFGgwBDLilwmu/lIQ6aGvQ7kRp XYe9TujRyGiqLtBNWH6Yz4U1SacrGQimo6MS5eD0= Received: by mail-wm1-f48.google.com with SMTP id z23so12588845wma.4 for ; Mon, 03 Jun 2019 14:37:30 -0700 (PDT) X-Gm-Message-State: APjAAAWwOxmH2ydNghHguBPPAzTXLH04w7lU+gjkZt7RIIjyQaBUdIBB L7IeFaqfpVJqIFtuUyLmd3OfWHE6NrDDXnQTxtRwHw== X-Google-Smtp-Source: APXvYqxdUr7TDIteSerX6UkuNzjBgbrWWlCpsdbDlcFwObi9TtMlsj3g3nDpINh3WF26sC6Rc/305H4m02M04UFf+ic= X-Received: by 2002:a1c:9a53:: with SMTP id c80mr9098862wme.173.1559597849219; Mon, 03 Jun 2019 14:37:29 -0700 (PDT) MIME-Version: 1.0 References: <960B34DE67B9E140824F1DCDEC400C0F654E965F@ORSMSX116.amr.corp.intel.com> <960B34DE67B9E140824F1DCDEC400C0F654E9824@ORSMSX116.amr.corp.intel.com> <20190528202407.GB13158@linux.intel.com> <285f279f-b500-27f0-ab42-fb1dbcc5ab18@tycho.nsa.gov> <960B34DE67B9E140824F1DCDEC400C0F654EB487@ORSMSX116.amr.corp.intel.com> <678a37af-797d-7bd5-a406-32548a270e3d@tycho.nsa.gov> <20190603205405.GE4894@linux.intel.com> In-Reply-To: <20190603205405.GE4894@linux.intel.com> From: Andy Lutomirski Date: Mon, 3 Jun 2019 14:37:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: SGX vs LSM (Re: [PATCH v20 00/28] Intel SGX1 support) To: Jarkko Sakkinen Cc: Andy Lutomirski , Stephen Smalley , "Xing, Cedric" , "Christopherson, Sean J" , William Roberts , James Morris , "Serge E. Hallyn" , LSM List , Paul Moore , Eric Paris , "selinux@vger.kernel.org" , Jethro Beekman , "Hansen, Dave" , Thomas Gleixner , "Dr. Greg" , Linus Torvalds , LKML , X86 ML , "linux-sgx@vger.kernel.org" , Andrew Morton , "nhorman@redhat.com" , "npmccallum@redhat.com" , "Ayoun, Serge" , "Katz-zamir, Shay" , "Huang, Haitao" , Andy Shevchenko , "Svahn, Kai" , Borislav Petkov , Josh Triplett , "Huang, Kai" , David Rientjes Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Jun 3, 2019 at 1:54 PM Jarkko Sakkinen wrote: > > On Thu, May 30, 2019 at 09:14:10AM -0700, Andy Lutomirski wrote: > > > What is the "source file" i.e. the target of the check? Enclave file, > > > sigstruct file, or /dev/sgx/enclave? > > > > Enclave file -- that is, the file backing the vma from which the data > > is loaded. > > Wonder why KVM gets away without having this given that enclaves are > lot alike VMs. > I would argue it's because access to /dev/kvm means you can execute whatever you code you want in a VM. I don't see how this is avoidable. On the other hand, it would be nice for SGX to not imply this same sort of "execute anything" right, especially since, unlike KVM, SGX is not a sandbox.