From: Ard Biesheuvel <ardb@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: James Bottomley <jejb@linux.ibm.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
keyrings@vger.kernel.org,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v3 0/2] use SM3 instead of SM3_256
Date: Tue, 26 Oct 2021 18:08:10 +0200 [thread overview]
Message-ID: <CAMj1kXGiC-LCc-50cfddJxJ-mezO=fcLqhJHiK110CgxKusy9w@mail.gmail.com> (raw)
In-Reply-To: <20211026075626.61975-1-tianjia.zhang@linux.alibaba.com>
On Tue, 26 Oct 2021 at 09:56, Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
> According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
> SM3 always produces a 256-bit hash value and there are no plans for
> other length development, so there is no ambiguity in the name of sm3.
>
What is the point of these changes? Having '256' in the identifiers is
merely redundant and not factually incorrect, so why can't we just
leave these as they are?
> ---
> v3 changes:
> - The fix of document trusted-encrypted.rst is put in patch 2
>
> v2 changes:
> - an additional macro with the same value is defined for uapi instead
> of renaming directly
>
> Tianjia Zhang (2):
> crypto: use SM3 instead of SM3_256
> tpm: use SM3 instead of SM3_256
>
> Documentation/security/keys/trusted-encrypted.rst | 2 +-
> crypto/hash_info.c | 4 ++--
> drivers/char/tpm/tpm-sysfs.c | 4 ++--
> drivers/char/tpm/tpm2-cmd.c | 2 +-
> include/crypto/hash_info.h | 2 +-
> include/linux/tpm.h | 2 +-
> include/uapi/linux/hash_info.h | 3 ++-
> security/keys/trusted-keys/trusted_tpm2.c | 2 +-
> 8 files changed, 11 insertions(+), 10 deletions(-)
>
> --
> 2.19.1.3.ge56e4f7
>
next prev parent reply other threads:[~2021-10-26 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 7:56 [PATCH v3 0/2] use SM3 instead of SM3_256 Tianjia Zhang
2021-10-26 7:56 ` [PATCH v3 1/2] crypto: " Tianjia Zhang
2021-10-28 6:44 ` Jarkko Sakkinen
2021-10-26 7:56 ` [PATCH v3 2/2] tpm: " Tianjia Zhang
2021-10-28 12:56 ` James Bottomley
2021-10-26 16:08 ` Ard Biesheuvel [this message]
2021-10-28 13:07 ` [PATCH v3 0/2] " James Bottomley
2021-11-29 13:01 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGiC-LCc-50cfddJxJ-mezO=fcLqhJHiK110CgxKusy9w@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).