From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "James Bottomley" <James.Bottomley@HansenPartnership.com>,
<linux-integrity@vger.kernel.org>
Cc: <keyrings@vger.kernel.org>, "Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"David Howells" <dhowells@redhat.com>,
"Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
<linux-kernel@vger.kernel.org>,
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] tpm: enable HMAC encryption for only x86-64 and aarch64
Date: Tue, 21 May 2024 17:26:54 +0300 [thread overview]
Message-ID: <D1FE58VX0KL4.70F6U9Y6HPQC@kernel.org> (raw)
In-Reply-To: <854fa2e1634eb116b979dab499243e40917c637c.camel@HansenPartnership.com>
On Tue May 21, 2024 at 5:13 PM EEST, James Bottomley wrote:
> On Tue, 2024-05-21 at 17:02 +0300, Jarkko Sakkinen wrote:
> > Secondly, it also roots to the null key if a parent is not given. So
> > it covers all the basic features of the HMAC patch set.
>
> I don't think that can work. The key file would be wrapped to the
> parent and the null seed (and hence the wrapping) changes with every
> reboot. If you want a permanent key, it has to be in one of the
> accessible permanent hierarchies (storage ideally or endorsement).
I'm fully aware that null seed is randomized per power cycle.
The fallback was inherited from James Prestwood's original code and I
decided to keep it as a testing feature, and also to test HMAC changes.
If you look at the testing transcript in the cover letter, it should be
obvious that a primary key is created in my basic test.
BR, Jarkko
next prev parent reply other threads:[~2024-05-21 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 13:09 [PATCH] tpm: enable HMAC encryption for only x86-64 and aarch64 Jarkko Sakkinen
2024-05-21 13:26 ` James Bottomley
2024-05-21 14:02 ` Jarkko Sakkinen
2024-05-21 14:13 ` James Bottomley
2024-05-21 14:26 ` Jarkko Sakkinen [this message]
2024-05-21 14:35 ` Jarkko Sakkinen
2024-05-21 14:56 ` James Bottomley
2024-05-21 15:02 ` Jarkko Sakkinen
2024-05-21 15:01 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1FE58VX0KL4.70F6U9Y6HPQC@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).