From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00E43154C19; Wed, 25 Sep 2024 07:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727250788; cv=none; b=rPOgEV1DsrnywXZJYBLxEsYpy81U2LB2B/xZsCF+aJr2p9rcMRkMbuikSktcwWa+JlIgYGDGvZIcj4LOIABTYai38KjhDKyocgjwn/qAbnRLWS44BA/kHsEyY+yw11BraRUuCX3O8tHIxIcdJg8c3/juRu7vwlLoSjcL1xlJa0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727250788; c=relaxed/simple; bh=JFD+/TLICslIFiwVPjoesgFsuWrdwIUahgsyCeOj96U=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=YrahciB5Jy6knaudVu4TzS2+j8SdlzYPGztpWtJ4APsrMCDa0eAw4SnihFtmeKPcKMUJ9B6P3LufHuY0Ww44tTHvDZKVhC9s4suYLwN/PqZtgNcF5G+jjlFkZ/ylZyBDhRin9qjeXlDhUxeJEUcHAddE68f3lfXJAb8EkCMfnug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L09mQInY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L09mQInY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AACBC4CEC3; Wed, 25 Sep 2024 07:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727250787; bh=JFD+/TLICslIFiwVPjoesgFsuWrdwIUahgsyCeOj96U=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=L09mQInYz84uGJZbZpBXxi9BygP+ozfZGhGlnbSuydVvehTh6L9NvfGD2UydxKfhL MEyFDvEZdwW4ZNQUIc929XNtKRRPo0xzQGqQfAdNbI0NlvNW0B+X7zGN5kmW5hSDC4 yis/qnvflml27pBWUodCn0jc/c3NZc4+B7M6qtxG7CoGXSGnHCKi1DpAfnYkdzPPx5 KL9qWYusc/Uc/H1A6o9JHV+Xl9AeQGGawy6VOADgfxrhLnSrWBmi1UQ110R3BmogeN 3ObjPdwJeCowTRjRUMoTqW0I0y3MBKixy3FBcg7ziotb0kxRNO+LnRJ1Uf2+TOnffk HW61NjouL8dOQ== Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Sep 2024 10:53:03 +0300 Message-Id: Cc: , , , "Mimi Zohar" , "David Howells" , "Paul Moore" , "James Morris" , "Serge E. Hallyn" , "Peter Huewe" , "Jason Gunthorpe" , , , Subject: Re: [PATCH v5 5/5] tpm: flush the auth session only when /dev/tpm0 is open From: "Jarkko Sakkinen" To: "Jarkko Sakkinen" , "James Bottomley" , X-Mailer: aerc 0.18.2 References: <20240921120811.1264985-1-jarkko@kernel.org> <20240921120811.1264985-6-jarkko@kernel.org> <00cf0bdb3ebfaec7c4607c8c09e55f2e538402f1.camel@HansenPartnership.com> <2b4c10ca905070158a4bc2fb78d5d5b0f32950ad.camel@HansenPartnership.com> In-Reply-To: On Wed Sep 25, 2024 at 10:46 AM EEST, Jarkko Sakkinen wrote: > On Wed Sep 25, 2024 at 10:42 AM EEST, Jarkko Sakkinen wrote: > > Fair enough. I can buy this. > > > > I'll phrase it that (since it was mentioned in the bugzilla comment) > > in the bug in question the root is in PCR extend but since in my own > > tests I got overhead from trusted keys I also mention that it overally > > affects also that and tpm2_get_random(). > > I do not want to take null key flushing away although I got the > reasoning given the small amount of time is saved (maybe 25-50 ms > in my QEMU setup if I recall correctly) but it would make sense to > squash it auth session patch. > > I'll also check 1/2 and 2/2 if I'm doing too much in them. Not > adding any tags to v6 and it really makes sense to develop=20 > benchmarks and not rush with the new version now that I got > also your feedback, since it is past rc1 timeline. > > Good target rcX would be around rc3. I have to admit this: I had blind spot on that PCR extend comment because I did not get hits on that when testing this so it definitely needs to be documented. I spotted it only yesterday. BR, Jarkko