From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "David Gstir" <david@sigma-star.at>,
"sigma star Kernel Team" <upstream+dcp@sigma-star.at>,
"James Bottomley" <jejb@linux.ibm.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"David Howells" <dhowells@redhat.com>,
"Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: "linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] KEYS: trusted: dcp: fix improper sg use with CONFIG_VMAP_STACK=y
Date: Tue, 07 Jan 2025 21:05:25 +0200 [thread overview]
Message-ID: <D6W2QCDWF7DN.UN4NFTJ0ESS5@kernel.org> (raw)
In-Reply-To: <CA61EE6A-F2D5-4812-96D4-4B1AF3B8B3ED@sigma-star.at>
On Tue Jan 7, 2025 at 2:56 PM EET, David Gstir wrote:
>
> > On 13.11.2024, at 22:27, David Gstir <david@sigma-star.at> wrote:
> >
> > With vmalloc stack addresses enabled (CONFIG_VMAP_STACK=y) DCP trusted
> > keys can crash during en- and decryption of the blob encryption key via
> > the DCP crypto driver. This is caused by improperly using sg_init_one()
> > with vmalloc'd stack buffers (plain_key_blob).
> >
> > Fix this by always using kmalloc() for buffers we give to the DCP crypto
> > driver.
> >
> > Cc: stable@vger.kernel.org # v6.10+
> > Fixes: 0e28bf61a5f9 ("KEYS: trusted: dcp: fix leak of blob encryption key")
> > Signed-off-by: David Gstir <david@sigma-star.at>
>
> gentle ping.
It's done, thanks for reminding, and don't hesitate to do it earlier
if this ever happens again.
>
> Thanks!
> - David
BR, Jarkko
next prev parent reply other threads:[~2025-01-07 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 21:27 [PATCH] KEYS: trusted: dcp: fix improper sg use with CONFIG_VMAP_STACK=y David Gstir
2025-01-07 12:56 ` David Gstir
2025-01-07 19:05 ` Jarkko Sakkinen [this message]
2025-01-07 19:05 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6W2QCDWF7DN.UN4NFTJ0ESS5@kernel.org \
--to=jarkko@kernel.org \
--cc=david@sigma-star.at \
--cc=dhowells@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
--cc=upstream+dcp@sigma-star.at \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).