Re: [PATCH] security: keys: Make sysctl table const

["Ricardo B. Marlière" <rbm@suse.com>]

Hi Paul,

On Wed Feb 26, 2025 at 9:21 PM -03, Paul Moore wrote:
> On Thu, Jan 23, 2025 at 2:50 PM Ricardo B. Marliere
> <ricardo@marliere.net> wrote:
>>
>> Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
>> ctl_table"), the sysctl registration API allows for struct ctl_table to be
>> in read-only memory. Move key_sysctls to be declared at build time, instead
>> of having to be dynamically allocated at boot time.
>>
>> Cc: Thomas Weißschuh <linux@weissschuh.net>
>> Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
>> Signed-off-by: Ricardo B. Marliere <rbm@suse.com>
>> ---
>>  security/keys/sysctl.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Looks fine to me.  David or Jarkko, this looks like something for the
> keys tree, yes?
>
> Reviewed-by: Paul Moore <paul@paul-moore.com>

Thank you for the review, but I believe this has been done here:

https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1751f872cc97f992ed5c4c72c55588db1f0021e1

>
>> diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c
>> index 91f000eef3ad82370250e5238d9c9c80757aab61..cde08c478f3272081304e6db34e36b64ce0d321a 100644
>> --- a/security/keys/sysctl.c
>> +++ b/security/keys/sysctl.c
>> @@ -9,7 +9,7 @@
>>  #include <linux/sysctl.h>
>>  #include "internal.h"
>>
>> -static struct ctl_table key_sysctls[] = {
>> +static const struct ctl_table key_sysctls[] = {
>>         {
>>                 .procname = "maxkeys",
>>                 .data = &key_quota_maxkeys,
>>
>> ---
>> base-commit: 714d87c90a766e6917f7d69f618b864d350f09d3
>> change-id: 20250123-sysctl_const-pcmoore-fa14389b8329
>>
>> Best regards,
>> --
>> Ricardo B. Marliere <rbm@suse.com>