From: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>
To: "KP Singh" <kpsingh@kernel.org>, <bpf@vger.kernel.org>,
<linux-security-module@vger.kernel.org>
Cc: <ast@kernel.org>, <daniel@iogearbox.net>,
"Xianrui Dong" <dongxianrui1@gmail.com>
Subject: Re: [PATCH v2] bpf: reject NULL data/sig in bpf_verify_pkcs7_signature
Date: Wed, 20 May 2026 05:23:46 +0200 [thread overview]
Message-ID: <DIN6KNJ9BUXI.2A1LG8WW3842M@gmail.com> (raw)
In-Reply-To: <20260520024059.313468-1-kpsingh@kernel.org>
On Wed May 20, 2026 at 4:40 AM CEST, KP Singh wrote:
> __bpf_dynptr_data() can return NULL (FILE dynptrs, any non-contiguous
> backing). bpf_verify_pkcs7_signature() forwards the pointer to
> verify_pkcs7_signature() unchecked, causing a NULL deref in
> asn1_ber_decoder() reachable from a sleepable BPF LSM at lsm.s/bpf.
>
> NULL-check both pointers and reject with -EINVAL. Mirrors the guards
> already in kernel/bpf/crypto.c.
>
> Fixes: 865b0566d8f1 ("bpf: Add bpf_verify_pkcs7_signature() kfunc")
> Reported-by: Xianrui Dong <dongxianrui1@gmail.com>
> Signed-off-by: KP Singh <kpsingh@kernel.org>
> ---
Added missing acks before pushing.
> [...]
next prev parent reply other threads:[~2026-05-20 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 2:40 [PATCH v2] bpf: reject NULL data/sig in bpf_verify_pkcs7_signature KP Singh
2026-05-20 3:23 ` Kumar Kartikeya Dwivedi [this message]
2026-05-20 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIN6KNJ9BUXI.2A1LG8WW3842M@gmail.com \
--to=memxor@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dongxianrui1@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox