From: "Gary Guo" <gary@garyguo.net>
To: "Trevor Chan" <trev@trevrosa.dev>, <gregkh@linuxfoundation.org>,
<rafael@kernel.org>, <dakr@kernel.org>, <ojeda@kernel.org>,
<a.hindborg@kernel.org>, <paul@paul-moore.com>,
<aliceryhl@google.com>, <airlied@gmail.com>, <simona@ffwll.ch>,
<viro@zeniv.linux.org.uk>, <brauner@kernel.org>,
<igor.korotin@linux.dev>, <vireshk@kernel.org>, <nm@ti.com>,
<sboyd@kernel.org>, <m.wilczynski@samsung.com>,
<boqun@kernel.org>, <gary@garyguo.net>, <axboe@kernel.dk>,
<daniel.almeida@collabora.com>, <shankari.ak0208@gmail.com>,
<lyude@redhat.com>, <j@jananu.net>, <lossin@kernel.org>,
<acourbot@nvidia.com>, <markus.probst@posteo.de>,
<driver-core@lists.linux.dev>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-pm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-pwm@vger.kernel.org>
Cc: <david.m.ertman@intel.com>, <iweiny@kernel.org>,
<leon@kernel.org>, <bjorn3_gh@protonmail.com>,
<tmgross@umich.edu>, <tamird@kernel.org>, <work@onurozkan.dev>,
<sergeh@kernel.org>, <matthew.brost@intel.com>,
<thomas.hellstrom@linux.intel.com>, <jack@suse.cz>,
<ljs@kernel.org>, <liam@infradead.org>, <bhelgaas@google.com>,
<kwilczynski@kernel.org>, <ptikhomirov@virtuozzo.com>
Subject: Re: [PATCH v6] rust: aref: make `AlwaysRefCounted::inc_ref` an associated function
Date: Mon, 29 Jun 2026 15:37:34 +0100 [thread overview]
Message-ID: <DJLLYCLQEBV0.2L6F55OJ8A6B@garyguo.net> (raw)
In-Reply-To: <20260628095132.47753-1-trev@trevrosa.dev>
On Sun Jun 28, 2026 at 10:51 AM BST, Trevor Chan wrote:
> `AlwaysRefCounted::inc_ref` is a function that shouldn't be called lightly.
>
> To prevent accidentally calling it, change `inc_ref` to be an associated function.
>
> Modify all `AlwaysRefCounted` implementors to work with this change.
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1177
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Trevor Chan <trev@trevrosa.dev>
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> Changes in v2:
> - Don't word wrap the patch
> Changes in v3:
> - Make argument name of `Empty::inc_ref` consistent with `Empty::dec_ref`
> Changes in v4:
> - Rebase to new rust-next, change new implementors
> - Reword explanation for change in `AlwaysRefCounted::inc_ref` doc comment
> Changes in v5:
> - Change commit message to be imperative
> Changes in v6:
> - Change all the implementors
> ---
> rust/kernel/auxiliary.rs | 4 ++--
> rust/kernel/block/mq/request.rs | 4 ++--
> rust/kernel/cred.rs | 4 ++--
> rust/kernel/device.rs | 4 ++--
> rust/kernel/device/property.rs | 4 ++--
> rust/kernel/drm/device.rs | 4 ++--
> rust/kernel/drm/gem/mod.rs | 4 ++--
> rust/kernel/drm/gpuvm/mod.rs | 4 ++--
> rust/kernel/drm/gpuvm/vm_bo.rs | 4 ++--
> rust/kernel/fs/file.rs | 8 ++++----
> rust/kernel/i2c.rs | 8 ++++----
> rust/kernel/mm.rs | 8 ++++----
> rust/kernel/mm/mmput_async.rs | 4 ++--
> rust/kernel/opp.rs | 4 ++--
> rust/kernel/pci.rs | 4 ++--
> rust/kernel/pid_namespace.rs | 4 ++--
> rust/kernel/platform.rs | 4 ++--
> rust/kernel/pwm.rs | 2 +-
> rust/kernel/sync/aref.rs | 11 +++++++----
> rust/kernel/task.rs | 4 ++--
> rust/kernel/usb.rs | 8 ++++----
> 21 files changed, 54 insertions(+), 51 deletions(-)
prev parent reply other threads:[~2026-06-29 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 9:51 [PATCH v6] rust: aref: make `AlwaysRefCounted::inc_ref` an associated function Trevor Chan
2026-06-29 14:37 ` Gary Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJLLYCLQEBV0.2L6F55OJ8A6B@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=brauner@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=david.m.ertman@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=igor.korotin@linux.dev \
--cc=iweiny@kernel.org \
--cc=j@jananu.net \
--cc=jack@suse.cz \
--cc=kwilczynski@kernel.org \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=m.wilczynski@samsung.com \
--cc=markus.probst@posteo.de \
--cc=matthew.brost@intel.com \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=paul@paul-moore.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sergeh@kernel.org \
--cc=shankari.ak0208@gmail.com \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tmgross@umich.edu \
--cc=trev@trevrosa.dev \
--cc=vireshk@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox