From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA340C433E6 for ; Fri, 12 Feb 2021 23:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E5E664E26 for ; Fri, 12 Feb 2021 23:48:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbhBLXsF (ORCPT ); Fri, 12 Feb 2021 18:48:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:51948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbhBLXsE (ORCPT ); Fri, 12 Feb 2021 18:48:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8AB3E64DCF; Fri, 12 Feb 2021 23:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613173644; bh=xKxZHu5u1kUN06z90+05/IXtEvmadhO6jaD+PVJY1RE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Webl567KKKD+O/EplL47+ZNU0enwE3KwX1dkpf1FNV44XJWUFykJG9txa49s4crVF lMXnrHzc2/6wt3Qw1y4UD/PVNJC0pU00FK6kKo0jDHDP/rBganpLHzvtbIUt2GW+fI O/UPv9Fv6YJS/wdMri6gA8K1YA/5Q4dwjKmoFJkcKPjOrGWVvNk2+7huXPMgBTTrcv 6Y5WPRxQ6sy3IpudqHHu5ldHk9DjJgw+p7SsBvYdbnSh6Es2Uh6QxmgQPuTnqKfxeb 2/bzdDaS/Vh0hZGqF1Yjx9y1f3p7zKxvbr4BXNBM0rsvSMZIZw/YrCEqhaPF8XiXM1 AaoT+Om/goJKA== Date: Sat, 13 Feb 2021 01:47:14 +0200 From: Jarkko Sakkinen To: Nayna Jain Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, David Howells , Jarkko Sakkinen , Mimi Zohar , Linux Kernel Mailing List Subject: Re: [PATCH 1/5] keys: cleanup build time module signing keys Message-ID: References: <20210211195435.135582-1-nayna@linux.ibm.com> <20210211195435.135582-2-nayna@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210211195435.135582-2-nayna@linux.ibm.com> Precedence: bulk List-ID: On Thu, Feb 11, 2021 at 02:54:31PM -0500, Nayna Jain wrote: > The "mrproper" target is still looking for build time generated keys > in the old path instead of certs/ directory. > This patch fixes the path as well removes the names of the files which > are no longer generated. "Fix the path..." > Signed-off-by: Nayna Jain > Fixes: 28a68f828266 ("modsign: Use single PEM file for autogenerated key") Swap the order. /Jarkko > --- > Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index ade44ac4cc2f..af18aab6bbee 100644 > --- a/Makefile > +++ b/Makefile > @@ -1472,9 +1472,9 @@ MRPROPER_FILES += include/config include/generated \ > debian snap tar-install \ > .config .config.old .version \ > Module.symvers \ > - signing_key.pem signing_key.priv signing_key.x509 \ > - x509.genkey extra_certificates signing_key.x509.keyid \ > - signing_key.x509.signer vmlinux-gdb.py \ > + certs/signing_key.pem certs/signing_key.x509 \ > + certs/x509.genkey \ > + vmlinux-gdb.py \ > *.spec > > # Directories & files removed with 'make distclean' > -- > 2.18.1 > >