linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Nayna Jain <nayna@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
	dhowells@redhat.com, zohar@linux.ibm.com,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, dimitri.ledkov@canonical.com,
	seth@forshee.me, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v6 1/3] certs: export load_certificate_list() to be used outside certs/
Date: Wed, 29 Dec 2021 03:29:50 +0200	[thread overview]
Message-ID: <Ycu6Dq1Tq2cqq/Lf@iki.fi> (raw)
In-Reply-To: <20211223013919.206273-2-nayna@linux.ibm.com>

On Wed, Dec 22, 2021 at 08:39:17PM -0500, Nayna Jain wrote:
> load_certificate_list() parses certificates embedded in the kernel
> image to load them onto the keyring.
> 
> Commit "2565ca7f5ec1 (certs: Move load_system_certificate_list to a common
> function)" made load_certificate_list() a common function in the certs/
> directory. Now, export load_certificate_list() outside certs/ to be used
> by other functions.

It is exported to make callable by load_platform_certificate_list(). Making
anything callable by other functions by itself has no inherit value, and
does not serve as a stimulus to make such code change.

/Jarkko

  reply	other threads:[~2021-12-29  1:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23  1:39 [PATCH v6 0/3] integrity: support including firmware ".platform" keys at build time Nayna Jain
2021-12-23  1:39 ` [PATCH v6 1/3] certs: export load_certificate_list() to be used outside certs/ Nayna Jain
2021-12-29  1:29   ` Jarkko Sakkinen [this message]
2021-12-23  1:39 ` [PATCH v6 2/3] integrity: make integrity_keyring_from_id() non-static Nayna Jain
2021-12-23  1:39 ` [PATCH v6 3/3] integrity: support including firmware ".platform" keys at build time Nayna Jain
2021-12-29  1:33   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ycu6Dq1Tq2cqq/Lf@iki.fi \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=dimitri.ledkov@canonical.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nayna@linux.ibm.com \
    --cc=seth@forshee.me \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).