From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F204AC433EF for ; Wed, 19 Jan 2022 21:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244031AbiASVF1 (ORCPT ); Wed, 19 Jan 2022 16:05:27 -0500 Received: from mga02.intel.com ([134.134.136.20]:60076 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbiASVFZ (ORCPT ); Wed, 19 Jan 2022 16:05:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642626325; x=1674162325; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3TDiFifv04AcCVYzOm6HZ64dJH3KSAV3f2PXyUIwWhM=; b=R0NNDNg+oL89hCIEiopjNT00tweh3W1TfwUR0AxFC77+bQIaLEO7OHTs TzChL0unoy6nhwWPpSuWytNV8+s0RcOBfcuaUibhIi77RNYm3NgTBaBX/ adEZ3ixnv/dFl49+V9LMAI+V15+bA2WJJ1XNbOYJ2/r4G97dB1VmHLdH6 4lWXZF0YPQUWAJd22RSMItDER7HPpry7jkrRcUDMVoi55D5AqbdjQ/Ac4 QcaDZgVAo8ZNEMQarck21zArybA2jZvYmjBajWglTE14k0bkQGNHTs2Ow SfCmSgHibV782uQh7Zv3gDOBAumFcL3R2w6qLcQ/0e4j4I9ryfX8jxdSC A==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="232555374" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="232555374" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 13:05:25 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="765084718" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 13:05:17 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAI7i-00CH8V-7G; Wed, 19 Jan 2022 23:04:06 +0200 Date: Wed, 19 Jan 2022 23:04:05 +0200 From: Andy Shevchenko To: Steven Rostedt Cc: Sakari Ailus , Lucas De Marchi , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-security-module@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, Alex Deucher , Andrew Morton , Ben Skeggs , Christian =?iso-8859-1?Q?K=F6nig?= , Chris Wilson , Daniel Vetter , David Airlie , "David S . Miller" , Emma Anholt , Eryk Brol , Francis Laniel , Greg Kroah-Hartman , Harry Wentland , Jakub Kicinski , Jani Nikula , Joonas Lahtinen , Julia Lawall , Kentaro Takeda , Leo Li , Mikita Lipski , Petr Mladek , Rahul Lakkireddy , Raju Rangoju , Rasmus Villemoes , Rodrigo Vivi , Sergey Senozhatsky , Vishal Kulkarni Subject: Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> <20220119100635.6c45372b@gandalf.local.home> <20220119160017.65bd1fa5@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119160017.65bd1fa5@gandalf.local.home> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: On Wed, Jan 19, 2022 at 04:00:17PM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 21:25:08 +0200 > Andy Shevchenko wrote: > > > > I say keep it one line! > > > > > > Reviewed-by: Steven Rostedt (Google) > > > > I believe Sakari strongly follows the 80 rule, which means... > > Checkpatch says "100" I think we need to simply update the docs (the > documentation always lags the code ;-) The idea of checkpatch change is for old code to avoid tons of patches to satisfy 80 rule in (mostly) staging code. Some maintainers started / have been using relaxed approach. -- With Best Regards, Andy Shevchenko