From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: linux-kernel@vger.kernel.org, Sumit Garg <sumit.garg@linaro.org>,
James Bottomley <jejb@linux.ibm.com>,
Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: trusted: Avoid calling null function trusted_key_exit
Date: Mon, 21 Feb 2022 02:57:16 +0100 [thread overview]
Message-ID: <YhLxfHcCccNUAiIl@kernel.org> (raw)
In-Reply-To: <cda221fd-6481-598f-03ba-29d0b79af8b7@oracle.com>
On Mon, Feb 07, 2022 at 11:40:23AM -0600, Dave Kleikamp wrote:
> On 1/26/22 2:21PM, Jarkko Sakkinen wrote:
> > On Wed, Jan 26, 2022 at 12:41:55PM -0600, Dave Kleikamp wrote:
> > > If one loads and unloads the trusted module, trusted_key_exit can be
> > > NULL. Call it through static_call_cond() to avoid a kernel trap.
> > >
> > > Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
> > >
> > > Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> >
> > Please re-send with cc stable and the empty line removed and I'll pick it.
>
> I re-sent a v2, but haven't seen any response from you.
>
> I can send it again, or feel free to clean up those lines yourself.
>
> Thanks,
> Shaggy
I've applied the patch. Thank you, and apologies for the latency.
BR, Jarkko
prev parent reply other threads:[~2022-02-21 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:41 [PATCH] KEYS: trusted: Avoid calling null function trusted_key_exit Dave Kleikamp
2022-01-26 20:21 ` Jarkko Sakkinen
2022-02-07 17:40 ` Dave Kleikamp
2022-02-21 1:57 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhLxfHcCccNUAiIl@kernel.org \
--to=jarkko@kernel.org \
--cc=dave.kleikamp@oracle.com \
--cc=dhowells@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).