* [PATCH] keys/keyring: Fix typo in string
@ 2022-07-04 2:56 Li zeming
2022-07-05 13:32 ` David Howells
2022-07-11 2:52 ` Jarkko Sakkinen
0 siblings, 2 replies; 3+ messages in thread
From: Li zeming @ 2022-07-04 2:56 UTC (permalink / raw)
To: dhowells, jarkko, jmorris, serge
Cc: keyrings, linux-security-module, linux-kernel, kernel, Li zeming
Remove the repeated ',' from string
Signed-off-by: Li zeming <zeming@nfschina.com>
---
security/keys/keyring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/keys/keyring.c b/security/keys/keyring.c
index 5e6a90760753..c6c47ca9b57d 100644
--- a/security/keys/keyring.c
+++ b/security/keys/keyring.c
@@ -460,7 +460,7 @@ static int keyring_read_iterator(const void *object, void *data)
struct keyring_read_iterator_context *ctx = data;
const struct key *key = keyring_ptr_to_key(object);
- kenter("{%s,%d},,{%zu/%zu}",
+ kenter("{%s,%d},{%zu/%zu}",
key->type->name, key->serial, ctx->count, ctx->buflen);
if (ctx->count >= ctx->buflen)
@@ -484,7 +484,7 @@ static long keyring_read(const struct key *keyring,
struct keyring_read_iterator_context ctx;
long ret;
- kenter("{%d},,%zu", key_serial(keyring), buflen);
+ kenter("{%d},%zu", key_serial(keyring), buflen);
if (buflen & (sizeof(key_serial_t) - 1))
return -EINVAL;
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] keys/keyring: Fix typo in string
2022-07-04 2:56 [PATCH] keys/keyring: Fix typo in string Li zeming
@ 2022-07-05 13:32 ` David Howells
2022-07-11 2:52 ` Jarkko Sakkinen
1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2022-07-05 13:32 UTC (permalink / raw)
To: Li zeming
Cc: dhowells, jarkko, jmorris, serge, keyrings, linux-security-module,
linux-kernel, kernel
Li zeming <zeming@nfschina.com> wrote:
> - kenter("{%s,%d},,{%zu/%zu}",
> + kenter("{%s,%d},{%zu/%zu}",
> key->type->name, key->serial, ctx->count, ctx->buflen);
This changed, so yes, it can be fixed.
> - kenter("{%d},,%zu", key_serial(keyring), buflen);
> + kenter("{%d},%zu", key_serial(keyring), buflen);
This one's not a typo.
David
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] keys/keyring: Fix typo in string
2022-07-04 2:56 [PATCH] keys/keyring: Fix typo in string Li zeming
2022-07-05 13:32 ` David Howells
@ 2022-07-11 2:52 ` Jarkko Sakkinen
1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2022-07-11 2:52 UTC (permalink / raw)
To: Li zeming
Cc: dhowells, jmorris, serge, keyrings, linux-security-module,
linux-kernel, kernel
On Mon, Jul 04, 2022 at 10:56:10AM +0800, Li zeming wrote:
> Remove the repeated ',' from string
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> security/keys/keyring.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/keys/keyring.c b/security/keys/keyring.c
> index 5e6a90760753..c6c47ca9b57d 100644
> --- a/security/keys/keyring.c
> +++ b/security/keys/keyring.c
> @@ -460,7 +460,7 @@ static int keyring_read_iterator(const void *object, void *data)
> struct keyring_read_iterator_context *ctx = data;
> const struct key *key = keyring_ptr_to_key(object);
>
> - kenter("{%s,%d},,{%zu/%zu}",
> + kenter("{%s,%d},{%zu/%zu}",
> key->type->name, key->serial, ctx->count, ctx->buflen);
>
> if (ctx->count >= ctx->buflen)
> @@ -484,7 +484,7 @@ static long keyring_read(const struct key *keyring,
> struct keyring_read_iterator_context ctx;
> long ret;
>
> - kenter("{%d},,%zu", key_serial(keyring), buflen);
> + kenter("{%d},%zu", key_serial(keyring), buflen);
>
> if (buflen & (sizeof(key_serial_t) - 1))
> return -EINVAL;
> --
> 2.18.2
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-11 2:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-04 2:56 [PATCH] keys/keyring: Fix typo in string Li zeming
2022-07-05 13:32 ` David Howells
2022-07-11 2:52 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).