From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6421BECAAD9 for ; Fri, 26 Aug 2022 14:47:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344573AbiHZOrR (ORCPT ); Fri, 26 Aug 2022 10:47:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344591AbiHZOrD (ORCPT ); Fri, 26 Aug 2022 10:47:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 049E9D8B25; Fri, 26 Aug 2022 07:46:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5297A61E6F; Fri, 26 Aug 2022 14:46:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F761C433D6; Fri, 26 Aug 2022 14:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661525218; bh=lSndhZ2rdlYCYSF4fsTiUalCAvFT7xxht3MoYvAbmAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XTy9Za+0gzR2PhxXOWTrsWMpqQzJfDzqOBQRhpkdKcMhol7PjnAUVgfDXR3ZtPve7 vNhI9pi5HDLLwq+/NhZnNkKXyLEPqSwiYCc1Cf1WLXglToMXjzk2vHvR/bczAey18g j38me5SPTTpnVH4Hw3T02ymOapK2MBOwifELna+W+EsNKazytkdQpzek3Oq4h9+NRA sPeSsG3R/1cca24czOCNfOSRx6rS4tix+xbMRzfN1ps2SL/ZY18alJ60wX+YmHtKkM axCSiMuzeGJmO0YAUnzKiNk1pIq6Pryd+ZAYLydds2jvnfosyGhF/6XF1TTwNmSpw+ aIqupDvKMSSWA== Date: Fri, 26 Aug 2022 17:46:51 +0300 From: Jarkko Sakkinen To: Alexei Starovoitov Cc: roberto.sassu@huaweicloud.com, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Jonathan Corbet , David Howells , Steven Rostedt , Ingo Molnar , Paul Moore , James Morris , "Serge E . Hallyn" , Shuah Khan , bpf , "open list:DOCUMENTATION" , keyrings@vger.kernel.org, LSM List , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Daniel =?iso-8859-1?Q?M=FCller?= , Roberto Sassu , Joanne Koong Subject: Re: [PATCH v12 02/10] btf: Handle dynamic pointer parameter in kfuncs Message-ID: References: <20220818152929.402605-1-roberto.sassu@huaweicloud.com> <20220818152929.402605-3-roberto.sassu@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Fri, Aug 26, 2022 at 05:43:50PM +0300, Jarkko Sakkinen wrote: > On Fri, Aug 26, 2022 at 08:46:14AM +0300, Jarkko Sakkinen wrote: > > On Thu, Aug 25, 2022 at 10:16:14PM -0700, Alexei Starovoitov wrote: > > > On Thu, Aug 25, 2022 at 9:54 PM Jarkko Sakkinen wrote: > > > > > > > > > > -static bool is_dynptr_reg_valid_init(struct bpf_verifier_env *env, struct bpf_reg_state *reg, > > > > > - enum bpf_arg_type arg_type) > > > > > +bool is_dynptr_reg_valid_init(struct bpf_verifier_env *env, struct bpf_reg_state *reg, > > > > > + enum bpf_arg_type arg_type) > > > > > { > > > > > struct bpf_func_state *state = func(env, reg); > > > > > int spi = get_spi(reg->off); > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > > > Might be niticking but generally I'd consider splitting > > > > exports as commits of their own. > > > > > > -static bool > > > +bool > > > > > > into a separate commit? > > > > > > I guess it makes sense for people whose salary depends on > > > number of commits. > > > We don't play these games. > > > > What kind of argument is that anyway. > > "Separate each *logical change* into a separate patch." [*] > > To add, generally any user space visible space should be an ~~~~~ change BR, Jarkko