* [PATCH 1/1] keys/request_key_auth.c: Use strscpy instead of strlcpy
@ 2022-09-05 16:07 Petr Vorel
2022-09-06 5:24 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Petr Vorel @ 2022-09-05 16:07 UTC (permalink / raw)
To: keyrings
Cc: Petr Vorel, David Howells, James Morris, Paul Moore,
Jarkko Sakkinen, linux-security-module
strlcpy is deprecated, use its safer replacement.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
security/keys/request_key_auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/request_key_auth.c b/security/keys/request_key_auth.c
index 41e9735006d0..8f33cd170e42 100644
--- a/security/keys/request_key_auth.c
+++ b/security/keys/request_key_auth.c
@@ -178,7 +178,7 @@ struct key *request_key_auth_new(struct key *target, const char *op,
if (!rka->callout_info)
goto error_free_rka;
rka->callout_len = callout_len;
- strlcpy(rka->op, op, sizeof(rka->op));
+ strscpy(rka->op, op, sizeof(rka->op));
/* see if the calling process is already servicing the key request of
* another process */
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] keys/request_key_auth.c: Use strscpy instead of strlcpy
2022-09-05 16:07 [PATCH 1/1] keys/request_key_auth.c: Use strscpy instead of strlcpy Petr Vorel
@ 2022-09-06 5:24 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2022-09-06 5:24 UTC (permalink / raw)
To: Petr Vorel
Cc: keyrings, David Howells, James Morris, Paul Moore,
linux-security-module
On Mon, Sep 05, 2022 at 06:07:03PM +0200, Petr Vorel wrote:
> strlcpy is deprecated, use its safer replacement.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> security/keys/request_key_auth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/keys/request_key_auth.c b/security/keys/request_key_auth.c
> index 41e9735006d0..8f33cd170e42 100644
> --- a/security/keys/request_key_auth.c
> +++ b/security/keys/request_key_auth.c
> @@ -178,7 +178,7 @@ struct key *request_key_auth_new(struct key *target, const char *op,
> if (!rka->callout_info)
> goto error_free_rka;
> rka->callout_len = callout_len;
> - strlcpy(rka->op, op, sizeof(rka->op));
> + strscpy(rka->op, op, sizeof(rka->op));
>
> /* see if the calling process is already servicing the key request of
> * another process */
> --
> 2.35.3
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-06 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-05 16:07 [PATCH 1/1] keys/request_key_auth.c: Use strscpy instead of strlcpy Petr Vorel
2022-09-06 5:24 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).