From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B513ECAAD5 for ; Tue, 6 Sep 2022 11:44:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232608AbiIFLn7 (ORCPT ); Tue, 6 Sep 2022 07:43:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232233AbiIFLn6 (ORCPT ); Tue, 6 Sep 2022 07:43:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA4FF32EFA; Tue, 6 Sep 2022 04:43:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 862C8614D5; Tue, 6 Sep 2022 11:43:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72430C433D6; Tue, 6 Sep 2022 11:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662464637; bh=AehOEKhpmpH1FHjym6CQIW6lvwPUnU6KzriMmKjXbRI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qU/E7xRE1iuF0V2oUvMrbwhZikLmOmNx8whkru0Ru9GU3BXYPEWjCBWSVyYkfIdnC OXqUP1bOMJjkIVNSIh4DJHEcyJgTxOJp7/gv3nbr2RjRw7PRDi0KBozXb+GDhHm8qT 0/k3TfwjyqTMe9VUl0fzx10JGM96c7jGp41yo6gQvVCf6sAM58dNACf0HeUmh37dBx Sq5m4XzPPHF/h01OvKRM1LERn6EXvwsd5RXI54z1/81IgJQTbKLrCf+X6xtXHI3DMt 50L5EBM5xHbt9RCitv8RIToNDz6wul+op7d1kRfIIO0mEzUO7GxjB/oTxJqoJ3A89o uLK4cAfjwZmzg== Date: Tue, 6 Sep 2022 14:43:53 +0300 From: Jarkko Sakkinen To: Roberto Sassu Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, mykolal@fb.com, dhowells@redhat.com, rostedt@goodmis.org, mingo@redhat.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, shuah@kernel.org, bpf@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, deso@posteo.net, memxor@gmail.com, Roberto Sassu Subject: Re: [PATCH v16 05/12] KEYS: Move KEY_LOOKUP_ to include/linux/key.h and define KEY_LOOKUP_ALL Message-ID: References: <20220905143318.1592015-1-roberto.sassu@huaweicloud.com> <20220905143318.1592015-6-roberto.sassu@huaweicloud.com> <394ed3b5f96afd3cf39e99675be1a32c89c8080d.camel@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Tue, Sep 06, 2022 at 01:04:35PM +0200, Roberto Sassu wrote: > On Tue, 2022-09-06 at 13:37 +0300, Jarkko Sakkinen wrote: > > On Tue, Sep 06, 2022 at 09:08:23AM +0200, Roberto Sassu wrote: > > > On Tue, 2022-09-06 at 00:38 +0300, Jarkko Sakkinen wrote: > > > > On Mon, Sep 05, 2022 at 04:33:11PM +0200, Roberto Sassu wrote: > > > > > From: Roberto Sassu > > > > > > > > > > In preparation for the patch that introduces the > > > > > bpf_lookup_user_key() eBPF > > > > > kfunc, move KEY_LOOKUP_ definitions to include/linux/key.h, to > > > > > be > > > > > able to > > > > > validate the kfunc parameters. Add them to enum > > > > > key_lookup_flag, so > > > > > that > > > > > all the current ones and the ones defined in the future are > > > > > automatically > > > > > exported through BTF and available to eBPF programs. > > > > > > > > > > Also, add KEY_LOOKUP_ALL to the enum, to facilitate checking > > > > > whether a > > > > > variable contains only defined flags. > > > > > > > > > > Signed-off-by: Roberto Sassu > > > > > Reviewed-by: KP Singh > > > > > Acked-by: Jarkko Sakkinen > > > > > > > > You should remove ack if there is any substantial change. > > > > > > Yes, sorry. I thought you were fine with the change due to: > > > > > > https://lore.kernel.org/bpf/YxF4H9MTDj+PnJ+V@kernel.org/ > > > > It was the documentation part, not really the enum change. > > > > Ok, so if I remove the documentation I can keep your ack? Can you show the updated patch (e.g. via using attachment)? BR, Jarkko