From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10826C38145 for ; Thu, 8 Sep 2022 05:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbiIHFRX (ORCPT ); Thu, 8 Sep 2022 01:17:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbiIHFRV (ORCPT ); Thu, 8 Sep 2022 01:17:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024D6BD1F2; Wed, 7 Sep 2022 22:17:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A4C27B81F05; Thu, 8 Sep 2022 05:17:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17C45C433C1; Thu, 8 Sep 2022 05:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662614237; bh=aY+4jyT4b1htONdVNHh0+w7cNyo+79xZD5hrCdXk8dk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n5pKL/olty8aLxKn+CXfeqTREfa79fOg2uq7sV1L01DqLgActG1aXxl+0oG9lyseS 5WK1SAWX+97YNtmfxmBq+AQ7j7972P96CPf0TPdNp/v+GQXO8HTCNy9oAd3U3W4cDM flqxEZu9kOUVAyuAGMq73634K+1JtJ1bcGLWh6k89KKEFwgeFoYuLxGzVIi6OEAz4A 06+mWlK0PZAd9ZKVSjnF3XW/riivc118E/77O8VhnfTbPFPVR7dQhteO/AGPTZWNAK lrEPRsPzKoPkGfR2fO3isX//2gJDeweerOOsscHrt2JR9oO/XRlLdya23ApJ8ENcRt vMfvELMKuyo9w== Date: Thu, 8 Sep 2022 08:17:11 +0300 From: Jarkko Sakkinen To: Paul Moore Cc: Randy Dunlap , Vincenzo Frascino , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells , James Morris Subject: Re: [PATCH] security/keys: Remove inconsistent __user annotation Message-ID: References: <20220907121230.21252-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Wed, Sep 07, 2022 at 11:43:17AM -0400, Paul Moore wrote: > On Wed, Sep 7, 2022 at 10:06 AM Randy Dunlap wrote: > > On 9/7/22 05:12, Vincenzo Frascino wrote: > > > The declaration of keyring_read does not match the definition > > > (security/keys/keyring.c). In this case the definition is correct > > > because it matches what defined in "struct key_type::read" > > > (linux/key-type.h). > > > > > > Fix the declaration removing the inconsistent __user annotation. > > > > > > Cc: David Howells > > > Cc: Jarkko Sakkinen > > > Cc: Paul Moore > > > Cc: James Morris > > > Signed-off-by: Vincenzo Frascino > > > --- > > > Note: This issue was discovered during the porting of the linux kernel > > > on Morello [1]. > > > > > > [1] https://git.morello-project.org/morello/kernel/linux > > > > FTR, I have sent this same patch 3 times. > > Good luck. > > David or Jarkko, this patch is both trivial and obviously correct, > please merge this into the keys tree for the next merge window else > I'll take it via the LSM tree. > > Reviewed-by: Paul Moore I picked it to my tree. BR, Jarkko