Re: [PATCH v6 00/16] perf tools: Use generic syscall scripts for all archs

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Fri, Jan 10, 2025 at 12:34:46PM +0530, Athira Rajeev wrote:
> 
> 
> > On 10 Jan 2025, at 2:44 AM, Charlie Jenkins <charlie@rivosinc.com> wrote:
> > 
> > On Thu, Jan 09, 2025 at 05:49:39PM -0300, Arnaldo Carvalho de Melo wrote:
> >> On Thu, Jan 09, 2025 at 11:48:36AM -0800, Charlie Jenkins wrote:
> >>> On Thu, Jan 09, 2025 at 12:59:43PM -0300, Arnaldo Carvalho de Melo wrote:
> >>>> ⬢ [acme@toolbox perf-tools-next]$ git log --oneline -1 ; time make -C tools/perf build-test
> >>>> d06826160a982494 (HEAD -> perf-tools-next) perf tools: Remove dependency on libaudit
> >>>> make: Entering directory '/home/acme/git/perf-tools-next/tools/perf'
> >>>> - tarpkg: ./tests/perf-targz-src-pkg .
> >>>>                 make_static: cd . && make LDFLAGS=-static NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 NO_JVMTI=1 NO_LIBTRACEEVENT=1 NO_LIBELF=1 -j28  DESTDIR=/tmp/tmp.JJT3tvN7bV
> >>>>              make_with_gtk2: cd . && make GTK2=1 -j28  DESTDIR=/tmp/tmp.BF53V2qpl3
> >>>> - /home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP: cd . && make FEATURE_DUMP_COPY=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP  feature-dump
> >>>> cd . && make FEATURE_DUMP_COPY=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump
> >>>>         make_no_libbionic_O: cd . && make NO_LIBBIONIC=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.KZuQ0q2Vs6 DESTDIR=/tmp/tmp.0sxMyH91gS
> >>>>           make_util_map_o_O: cd . && make util/map.o FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.Y0Mx3KLREI DESTDIR=/tmp/tmp.wg9HCVVLHE
> >>>>              make_install_O: cd . && make install FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.P0LEBAkW1X DESTDIR=/tmp/tmp.agTavZndFN
> >>>>  failed to find: etc/bash_completion.d/perf
> >>> 
> >>> Is this something introduced by this patch?
> >> 
> >> I don't think so.
> >> 
> >> BTW this series is already pushed out to perf-tools-next:
> >> 
> >> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next
> >> 
> >> Thanks!
> >> 
> >> - Arnaldo
> > 
> > Thank you!
> > 
> > - Charlie
> 
> Hi Charlie, Arnaldo
> 
> While testing the series, I hit compilation issue in powerpc
> 
> Snippet of logs:

Yeah, Stephen Rothwell noticed it in linux next and Charlie provided a
fix, so I squashed it all together and will push it soon:

    Link: https://lore.kernel.org/r/20250108-perf_syscalltbl-v6-14-7543b5293098@rivosinc.com
    Link: https://lore.kernel.org/lkml/20250110100505.78d81450@canb.auug.org.au
    [ Stephen Rothwell noticed on linux-next that the powerpc build for perf was broken and ...]
    Link: https://lore.kernel.org/lkml/20250109-perf_powerpc_spu-v1-1-c097fc43737e@rivosinc.com
    [ ... Charlie fixed it up and asked for it to be squashed to avoid breaking bisection. o

Thanks for the report!

- Arnaldo