From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Guo Ren" <guoren@kernel.org>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>, "Jonathan Corbet" <corbet@lwn.net>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-security-module@vger.kernel.org, bpf@vger.kernel.org,
linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 00/16] perf tools: Use generic syscall scripts for all archs
Date: Mon, 13 Jan 2025 11:55:02 -0300 [thread overview]
Message-ID: <Z4UpRqywqYPZSUM_@x1> (raw)
In-Reply-To: <Z4F1dXQLPGZ3JFI5@ghost>
On Fri, Jan 10, 2025 at 11:31:01AM -0800, Charlie Jenkins wrote:
> On Thu, Jan 09, 2025 at 03:00:59PM -0800, Charlie Jenkins wrote:
> > Ooh okay I see, the quiet commands were being ignored as-is. We could
> > add the lines to handle this to Makefile.syscalls, but I think the
> > better solution is to move the lines from Makefile.build to
> > Makefile.perf to be more generically available. Here is a patch for
> > that. I also added the comment from the kernel Makefile describing what
> > this does.
> > From 8dcec7f5d937ede3d33c687573dc2f1654ddc59e Mon Sep 17 00:00:00 2001
> > From: Charlie Jenkins <charlie@rivosinc.com>
> > Date: Thu, 9 Jan 2025 14:36:40 -0800
> > Subject: [PATCH] perf tools: Expose quiet/verbose variables in Makefile.perf
> >
> > The variables to make builds silent/verbose live inside
> > tools/build/Makefile.build. Move those variables to the top-level
> > Makefile.perf to be generally available.
<SNIP applied patch>
> Let me know how you want to handle this, I can send this out as a
> separate patch if that's better.
I used the patch you provided above after hand editing the message
before feeding it to 'git am', added these comments:
Committer testing:
See the SYSCALL lines, now they are consistent with the other
operations in other lines:
SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_32.h
SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_64.h
GEN /tmp/build/perf-tools-next/common-cmds.h
GEN /tmp/build/perf-tools-next/arch/arm64/include/generated/asm/sysreg-defs.h
PERF_VERSION = 6.13.rc2.g3d94bb6ed1d0
GEN perf-archive
MKDIR /tmp/build/perf-tools-next/jvmti/
MKDIR /tmp/build/perf-tools-next/jvmti/
MKDIR /tmp/build/perf-tools-next/jvmti/
MKDIR /tmp/build/perf-tools-next/jvmti/
GEN perf-iostat
CC /tmp/build/perf-tools-next/jvmti/libjvmti.o
CC /tmp/build/perf-tools-next/jvmti/jvmti_agent.o
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Thanks,
- Arnaldo
next prev parent reply other threads:[~2025-01-13 14:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 2:36 [PATCH v6 00/16] perf tools: Use generic syscall scripts for all archs Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 01/16] perf tools: Create generic syscall table support Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 02/16] perf tools: arc: Support generic syscall headers Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 03/16] perf tools: csky: " Charlie Jenkins
2025-01-09 3:22 ` Guo Ren
2025-01-09 2:36 ` [PATCH v6 04/16] perf tools: arm: Support " Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 05/16] perf tools: sh: " Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 06/16] perf tools: sparc: " Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 07/16] perf tools: xtensa: Support syscall header Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 08/16] perf tools: x86: Use generic syscall scripts Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 09/16] perf tools: alpha: Support syscall header Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 10/16] perf tools: parisc: " Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 11/16] perf tools: arm64: Use syscall table Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 12/16] perf tools: loongarch: " Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 13/16] perf tools: mips: Use generic syscall scripts Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 14/16] perf tools: powerpc: Use generic syscall table scripts Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 15/16] perf tools: s390: " Charlie Jenkins
2025-01-09 2:36 ` [PATCH v6 16/16] perf tools: Remove dependency on libaudit Charlie Jenkins
2025-01-09 15:59 ` [PATCH v6 00/16] perf tools: Use generic syscall scripts for all archs Arnaldo Carvalho de Melo
2025-01-09 19:48 ` Charlie Jenkins
2025-01-09 20:49 ` Arnaldo Carvalho de Melo
2025-01-09 21:14 ` Charlie Jenkins
2025-01-10 7:04 ` Athira Rajeev
2025-01-10 14:43 ` Arnaldo Carvalho de Melo
2025-01-11 14:03 ` Athira Rajeev
2025-01-09 21:51 ` Arnaldo Carvalho de Melo
2025-01-09 23:00 ` Charlie Jenkins
2025-01-10 19:31 ` Charlie Jenkins
2025-01-13 14:55 ` Arnaldo Carvalho de Melo [this message]
2025-01-14 17:58 ` Arnaldo Carvalho de Melo
2025-01-14 19:27 ` Charlie Jenkins
2025-01-14 22:00 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4UpRqywqYPZSUM_@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=charlie@rivosinc.com \
--cc=corbet@lwn.net \
--cc=gnoack@google.com \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mic@digikod.net \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).