From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6C5202C41 for ; Tue, 14 Jan 2025 19:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736882861; cv=none; b=cltseIXiCAylRSdUhAHCZs8rv+78dhpcS7g81vpb8DPjcfvVhK2ahPHlCZifJDObcbrvQHs+5PhnWBGlx/4/umEkREszLj97z7atGHdV9eol4++rrI3Wex3AN6yRNMjJoARh23VvUMQXix0aC0OcPuICw0b7srcbVNDPCEnAWD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736882861; c=relaxed/simple; bh=Uxw0taxwqk1Pq7X+X5K0+wSP4PXacCH+ZF9RVEkvz0M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dup6IBavBbKwe157+WugujRH+AQyz73bjdqKE99R6L0ofZUuz2V9u1ZqcdmgNLdKX/K4/PeXfn2uuV/BNkPKm5Clpi439EARG0qC4qO52M7Hu6iMuV1P/bxeNNJakw+ArYqRNkRPSBJi4HTCGuIbpr3E0W8SaW6E85BPeW2tT1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=wWgz3XtF; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="wWgz3XtF" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2166651f752so132801745ad.3 for ; Tue, 14 Jan 2025 11:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1736882857; x=1737487657; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ES4PfYVi7ZyhgRUm9GYH+FMCnEy4+AUcUAHWe5oV5jA=; b=wWgz3XtFKEYGCy0b4YoNhIb1fCXl/Z7F2KkJZlBmh3dRCLA2PvI48C7oqgDaE+pEqg FYyNAMsX0JfGGLTRLOehfKbYCTIGCjOIo7f6scTY6Yw8NsR1GCRa0DguFtaZFhWcghR2 x32iou7RzmiOp+lK3y6aveqa+rCM+X9+qwD8V4vbDYpNqAKbgvGDXo6MVVcgbeWMl/vf XPBI2cp7SpulNsG2uN+olI53aRT7Dejq3hBkE2fkAJIcVUkyH0NkIFA2vhtVJeh7gvBO nfHqYLSQV/iI4BwxjcZSNdGZwiBjQr/hzcITXsBTKsVF8RNU2JjifmvjoRYAzWmG5Hpd 54hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736882857; x=1737487657; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ES4PfYVi7ZyhgRUm9GYH+FMCnEy4+AUcUAHWe5oV5jA=; b=MZAvvup3yDdquj2avUFh/Kueif5kd4V7gEVpPwQ4n0+ADvwpe6YPW3KBL5JokQVguU 2EfDvSnkHv5xuvWyV5EFL5amnIKneO7eLcqUrWHAdhrlicB94G/aNKrjoQoCXmEs3sVK HDAZNyEIPPV40YRnL4SulpjghGzR4NYkqaiNw4YZg9yS9CxRSSH+B7qYaj8+2irM1B9q 3OF+5f+etDFXpW95MB8UTaKDYIOXl3aJoGCVS/5GnKWwBEbSj22UZ8+H4ot6lIJmGC+j 1s4X5YDdg/5WI+UJFYcPywcmXGvgMa322YsohxfBUWVdGuplBkEIG+WlnCTO0m3qOSy+ px7A== X-Forwarded-Encrypted: i=1; AJvYcCWpY6dK9YOT0BJ+pONcfR7wKTen48ivo1yL3kFg/BEeqzcWuNuKnV5+vDZXR4BetU3tkfl0LuFBAUlyUEFzXdR590/AwOk=@vger.kernel.org X-Gm-Message-State: AOJu0YxeytLP++WxdLPV7/ecwYunI2LGU9ce9S8mzhcrry798T0VJ59D Q1AiEdguRBGIMOnyYziTVQzZ+3nBkKwfiWVXQ8lI+9S/49ahmoHggWNKC+DzvfY= X-Gm-Gg: ASbGncuf3QZM/F2f7Y7HoqXCnB0LiX7z1PM1nSe+BIuHFSmBUIcfHZdEV+aKUfufGz7 IoA6z+qI/lYNQo5jS0IRMlm9a++BqGQr2gPv4AUhCCOYN9+C44qz9P7IRuQRhS20G8o749ybh+q g0N+XgG825MZh6UFvcUmCjnYlNO277bYOoxSvHkiq+YYu6syR+NNewZ6sHjBMMVDDV83SE98/Cm K7XPPUiTkqbf5ySqgt2nBJN/1JgdFZVnUEG6iFHhvn14/mX467f X-Google-Smtp-Source: AGHT+IHNba0GEbibje0t5wLZKfmTow6LQxoYMbmUndt+PVUCx5IeqgXnaaRg1lp0Qu+9TDj1PY7X3A== X-Received: by 2002:a17:902:d4cd:b0:216:3c2b:a5e5 with SMTP id d9443c01a7336-21a83f71115mr361190955ad.27.1736882856927; Tue, 14 Jan 2025 11:27:36 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:c3be:2c11:1223:572a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f10e006sm70578375ad.1.2025.01.14.11.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 11:27:34 -0800 (PST) Date: Tue, 14 Jan 2025 11:27:30 -0800 From: Charlie Jenkins To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , =?iso-8859-1?Q?G=FCnther?= Noack , Christian Brauner , Guo Ren , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Jonathan Corbet , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 00/16] perf tools: Use generic syscall scripts for all archs Message-ID: References: <20250108-perf_syscalltbl-v6-0-7543b5293098@rivosinc.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jan 14, 2025 at 02:58:26PM -0300, Arnaldo Carvalho de Melo wrote: > On Mon, Jan 13, 2025 at 11:55:05AM -0300, Arnaldo Carvalho de Melo wrote: > > On Fri, Jan 10, 2025 at 11:31:01AM -0800, Charlie Jenkins wrote: > > > On Thu, Jan 09, 2025 at 03:00:59PM -0800, Charlie Jenkins wrote: > > > > Ooh okay I see, the quiet commands were being ignored as-is. We could > > > > add the lines to handle this to Makefile.syscalls, but I think the > > > > better solution is to move the lines from Makefile.build to > > > > Makefile.perf to be more generically available. Here is a patch for > > > > that. I also added the comment from the kernel Makefile describing what > > > > this does. > > > > > > From 8dcec7f5d937ede3d33c687573dc2f1654ddc59e Mon Sep 17 00:00:00 2001 > > > > From: Charlie Jenkins > > > > Date: Thu, 9 Jan 2025 14:36:40 -0800 > > > > Subject: [PATCH] perf tools: Expose quiet/verbose variables in Makefile.perf > > > > > > > > The variables to make builds silent/verbose live inside > > > > tools/build/Makefile.build. Move those variables to the top-level > > > > Makefile.perf to be generally available. > > > > > > > > > Let me know how you want to handle this, I can send this out as a > > > separate patch if that's better. > > > > I used the patch you provided above after hand editing the message > > before feeding it to 'git am', added these comments: > > Somehow this is causing some trouble: > > ⬢ [acme@toolbox perf-tools-next]$ make -C tools/perf build-test > make: Entering directory '/home/acme/git/perf-tools-next/tools/perf' > - tarpkg: ./tests/perf-targz-src-pkg . > /bin/sh: line 1: @make: command not found > make[4]: *** [Makefile:27: clean-asm_pure_loop] Error 127 > make[3]: *** [Makefile.perf:764: tests-coresight-targets-clean] Error 2 > make[2]: *** [Makefile:96: clean] Error 2 > make[1]: *** [tests/make:330: make_static] Error 2 > make: *** [Makefile:109: build-test] Error 2 > make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf' > ⬢ [acme@toolbox perf-tools-next]$ > > Can you please try fixing it as I'm busy now (I'll be on vacation from > tomorrow till early February)? This is what I extracted: There was an erroneous $(Q) in tools/perf/tests/shell/coresight/Makefile. Previously it would expand to the empty string so wouldn't cause any problems, but now it's in the middle of an expression so hence the error. I'll send an updated patch. > > commit c199fd785d18121ffd0ba5758e23a42ba2984e11 > Author: Charlie Jenkins > Date: Mon Jan 13 11:50:55 2025 -0300 > > perf tools: Expose quiet/verbose variables in Makefile.perf > > The variables to make builds silent/verbose live inside > tools/build/Makefile.build. Move those variables to the top-level > Makefile.perf to be generally available. > > Committer testing: > > See the SYSCALL lines, now they are consistent with the other > operations in other lines: > > SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_32.h > SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_64.h > GEN /tmp/build/perf-tools-next/common-cmds.h > GEN /tmp/build/perf-tools-next/arch/arm64/include/generated/asm/sysreg-defs.h > PERF_VERSION = 6.13.rc2.g3d94bb6ed1d0 > GEN perf-archive > MKDIR /tmp/build/perf-tools-next/jvmti/ > MKDIR /tmp/build/perf-tools-next/jvmti/ > MKDIR /tmp/build/perf-tools-next/jvmti/ > MKDIR /tmp/build/perf-tools-next/jvmti/ > GEN perf-iostat > CC /tmp/build/perf-tools-next/jvmti/libjvmti.o > CC /tmp/build/perf-tools-next/jvmti/jvmti_agent.o > > Reported-by: Arnaldo Carvalho de Melo > Signed-off-by: Charlie Jenkins > Tested-by: Arnaldo Carvalho de Melo > Cc: Adrian Hunter > Cc: Alexander Shishkin > Cc: Arnd Bergmann > Cc: Christian Brauner > Cc: Guo Ren > Cc: Günther Noack > Cc: Ian Rogers > Cc: Ingo Molnar > Cc: James Clark > Cc: Jiri Olsa > Cc: John Garry > Cc: Jonathan Corbet > Cc: Leo Yan > Cc: Mark Rutland > Cc: Mickaël Salaün > Cc: Mike Leach > Cc: Namhyung Kim > Cc: Palmer Dabbelt > Cc: Paul Walmsley > Cc: Peter Zijlstra > Cc: Will Deacon > Link: http://lore.kernel.org/lkml/None > Signed-off-by: Arnaldo Carvalho de Melo > > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build > index 5fb3fb3d97e0fd11..e710ed67a1b49d9f 100644 > --- a/tools/build/Makefile.build > +++ b/tools/build/Makefile.build > @@ -12,26 +12,6 @@ > PHONY := __build > __build: > > -ifeq ($(V),1) > - quiet = > - Q = > -else > - quiet=quiet_ > - Q=@ > -endif > - > -# If the user is running make -s (silent mode), suppress echoing of commands > -# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS. > -ifeq ($(filter 3.%,$(MAKE_VERSION)),) > -short-opts := $(firstword -$(MAKEFLAGS)) > -else > -short-opts := $(filter-out --%,$(MAKEFLAGS)) > -endif > - > -ifneq ($(findstring s,$(short-opts)),) > - quiet=silent_ > -endif > - > build-dir := $(srctree)/tools/build > > # Define $(fixdep) for dep-cmd function > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index a449d00155364422..55d6ce9ea52fb2a5 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -161,12 +161,47 @@ export VPATH > SOURCE := $(shell ln -sf $(srctree)/tools/perf $(OUTPUT)/source) > endif > > +# Beautify output > +# --------------------------------------------------------------------------- > +# > +# Most of build commands in Kbuild start with "cmd_". You can optionally define > +# "quiet_cmd_*". If defined, the short log is printed. Otherwise, no log from > +# that command is printed by default. > +# > +# e.g.) > +# quiet_cmd_depmod = DEPMOD $(MODLIB) > +# cmd_depmod = $(srctree)/scripts/depmod.sh $(DEPMOD) $(KERNELRELEASE) > +# > +# A simple variant is to prefix commands with $(Q) - that's useful > +# for commands that shall be hidden in non-verbose mode. > +# > +# $(Q)$(MAKE) $(build)=scripts/basic > +# > +# To put more focus on warnings, be less verbose as default > +# Use 'make V=1' to see the full commands > + > ifeq ($(V),1) > + quiet = > Q = > else > - Q = @ > + quiet=quiet_ > + Q=@ > endif > > +# If the user is running make -s (silent mode), suppress echoing of commands > +# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS. > +ifeq ($(filter 3.%,$(MAKE_VERSION)),) > +short-opts := $(firstword -$(MAKEFLAGS)) > +else > +short-opts := $(filter-out --%,$(MAKEFLAGS)) > +endif > + > +ifneq ($(findstring s,$(short-opts)),) > + quiet=silent_ > +endif > + > +export quiet Q > + > # Do not use make's built-in rules > # (this improves performance and avoids hard-to-debug behaviour); > MAKEFLAGS += -r