From: Christoph Hellwig <hch@infradead.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "Günther Noack" <gnoack3000@gmail.com>,
"Günther Noack" <gnoack@google.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Paul Moore" <paul@paul-moore.com>,
"Dave Chinner" <david@fromorbit.com>,
"Kent Overstreet" <kent.overstreet@linux.dev>,
syzbot+34b68f850391452207df@syzkaller.appspotmail.com,
syzbot+360866a59e3c80510a62@syzkaller.appspotmail.com,
"Ubisectech Sirius" <bugreport@ubisectech.com>,
"Brian Foster" <bfoster@redhat.com>,
linux-bcachefs@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v1 1/2] landlock: Handle weird files
Date: Tue, 14 Jan 2025 23:15:42 -0800 [thread overview]
Message-ID: <Z4dgnkCOc_LxMqq2@infradead.org> (raw)
In-Reply-To: <20250111.PhoHophoh1zi@digikod.net>
On Sat, Jan 11, 2025 at 04:38:56PM +0100, Mickaël Salaün wrote:
> I guess it depends on the filesystem implementation. For instance, XFS
> returns an error if a weird file is detected [1], whereas bcachefs
> ignores it (which is considered a bug, but not fixed yet) [2].
If a filesyste, returns an invalid mode that's a file system bug and
needs to be fixed there. Warning in a consumer is perfectly fine.
But the right action in that case is indeed not to grant the access.
next prev parent reply other threads:[~2025-01-15 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 15:39 [PATCH v1 1/2] landlock: Handle weird files Mickaël Salaün
2025-01-10 15:39 ` [PATCH v1 2/2] landlock: Constify get_mode_access() Mickaël Salaün
2025-01-10 16:39 ` Günther Noack
2025-01-10 16:37 ` [PATCH v1 1/2] landlock: Handle weird files Günther Noack
2025-01-11 15:38 ` Mickaël Salaün
2025-01-15 7:15 ` Christoph Hellwig [this message]
2025-01-15 10:54 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4dgnkCOc_LxMqq2@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=bugreport@ubisectech.com \
--cc=david@fromorbit.com \
--cc=gnoack3000@gmail.com \
--cc=gnoack@google.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mic@digikod.net \
--cc=paul@paul-moore.com \
--cc=syzbot+34b68f850391452207df@syzkaller.appspotmail.com \
--cc=syzbot+360866a59e3c80510a62@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).