* [PATCH] landlock: fix grammar and spelling error
@ 2025-01-23 19:42 Tanya Agarwal
2025-01-24 9:24 ` Günther Noack
2025-01-24 11:36 ` Mickaël Salaün
0 siblings, 2 replies; 4+ messages in thread
From: Tanya Agarwal @ 2025-01-23 19:42 UTC (permalink / raw)
To: zohar, gnoack, mic, paul, jmorris, serge
Cc: linux-security-module, linux-kernel, skhan, anupnewsmail,
Tanya Agarwal
From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
Fix grammar and spelling error in landlock module comments that were
identified using the codespell tool.
No functional changes - documentation only.
Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
---
Original discussion:
https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com
This patch set is split into individual patches for each LSM
to facilitate easier review by respective maintainers.
security/landlock/ruleset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c
index a93bdbf52fff..c464d1f84792 100644
--- a/security/landlock/ruleset.c
+++ b/security/landlock/ruleset.c
@@ -121,7 +121,7 @@ create_rule(const struct landlock_id id,
return ERR_PTR(-ENOMEM);
RB_CLEAR_NODE(&new_rule->node);
if (is_object_pointer(id.type)) {
- /* This should be catched by insert_rule(). */
+ /* This should have been caught by insert_rule(). */
WARN_ON_ONCE(!id.key.object);
landlock_get_object(id.key.object);
}
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] landlock: fix grammar and spelling error
2025-01-23 19:42 [PATCH] landlock: fix grammar and spelling error Tanya Agarwal
@ 2025-01-24 9:24 ` Günther Noack
2025-01-24 11:36 ` Mickaël Salaün
1 sibling, 0 replies; 4+ messages in thread
From: Günther Noack @ 2025-01-24 9:24 UTC (permalink / raw)
To: Tanya Agarwal
Cc: zohar, mic, paul, jmorris, serge, linux-security-module,
linux-kernel, skhan, anupnewsmail
On Fri, Jan 24, 2025 at 01:12:10AM +0530, Tanya Agarwal wrote:
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
>
> Fix grammar and spelling error in landlock module comments that were
> identified using the codespell tool.
> No functional changes - documentation only.
>
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> Original discussion:
> https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com
>
> This patch set is split into individual patches for each LSM
> to facilitate easier review by respective maintainers.
>
> security/landlock/ruleset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c
> index a93bdbf52fff..c464d1f84792 100644
> --- a/security/landlock/ruleset.c
> +++ b/security/landlock/ruleset.c
> @@ -121,7 +121,7 @@ create_rule(const struct landlock_id id,
> return ERR_PTR(-ENOMEM);
> RB_CLEAR_NODE(&new_rule->node);
> if (is_object_pointer(id.type)) {
> - /* This should be catched by insert_rule(). */
> + /* This should have been caught by insert_rule(). */
> WARN_ON_ONCE(!id.key.object);
> landlock_get_object(id.key.object);
> }
> --
> 2.39.5
>
Reviewed-by: Günther Noack <gnoack@google.com>
Thanks!
—Günther
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] landlock: fix grammar and spelling error
2025-01-23 19:42 [PATCH] landlock: fix grammar and spelling error Tanya Agarwal
2025-01-24 9:24 ` Günther Noack
@ 2025-01-24 11:36 ` Mickaël Salaün
2025-01-24 16:04 ` Tanya Agarwal
1 sibling, 1 reply; 4+ messages in thread
From: Mickaël Salaün @ 2025-01-24 11:36 UTC (permalink / raw)
To: Tanya Agarwal
Cc: zohar, gnoack, paul, jmorris, serge, linux-security-module,
linux-kernel, skhan, anupnewsmail
On Fri, Jan 24, 2025 at 01:12:10AM +0530, Tanya Agarwal wrote:
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
>
> Fix grammar and spelling error in landlock module comments that were
> identified using the codespell tool.
> No functional changes - documentation only.
>
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
I think Mimi's tag was for the IMA part, so I'll remove it.
> ---
> Original discussion:
> https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com
>
> This patch set is split into individual patches for each LSM
> to facilitate easier review by respective maintainers.
>
> security/landlock/ruleset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c
> index a93bdbf52fff..c464d1f84792 100644
> --- a/security/landlock/ruleset.c
> +++ b/security/landlock/ruleset.c
> @@ -121,7 +121,7 @@ create_rule(const struct landlock_id id,
> return ERR_PTR(-ENOMEM);
> RB_CLEAR_NODE(&new_rule->node);
> if (is_object_pointer(id.type)) {
> - /* This should be catched by insert_rule(). */
> + /* This should have been caught by insert_rule(). */
> WARN_ON_ONCE(!id.key.object);
> landlock_get_object(id.key.object);
> }
Thanks, I'll take it in my tree.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] landlock: fix grammar and spelling error
2025-01-24 11:36 ` Mickaël Salaün
@ 2025-01-24 16:04 ` Tanya Agarwal
0 siblings, 0 replies; 4+ messages in thread
From: Tanya Agarwal @ 2025-01-24 16:04 UTC (permalink / raw)
To: Mickaël Salaün
Cc: zohar, gnoack, paul, jmorris, serge, linux-security-module,
linux-kernel, skhan, anupnewsmail
On Fri, Jan 24, 2025 at 5:06 PM Mickaël Salaün <mic@digikod.net> wrote:
>
> On Fri, Jan 24, 2025 at 01:12:10AM +0530, Tanya Agarwal wrote:
> > From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> >
> > Fix grammar and spelling error in landlock module comments that were
> > identified using the codespell tool.
> > No functional changes - documentation only.
> >
> > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
> I think Mimi's tag was for the IMA part, so I'll remove it.
>
> > ---
> > Original discussion:
> > https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com
> >
> > This patch set is split into individual patches for each LSM
> > to facilitate easier review by respective maintainers.
> >
> > security/landlock/ruleset.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c
> > index a93bdbf52fff..c464d1f84792 100644
> > --- a/security/landlock/ruleset.c
> > +++ b/security/landlock/ruleset.c
> > @@ -121,7 +121,7 @@ create_rule(const struct landlock_id id,
> > return ERR_PTR(-ENOMEM);
> > RB_CLEAR_NODE(&new_rule->node);
> > if (is_object_pointer(id.type)) {
> > - /* This should be catched by insert_rule(). */
> > + /* This should have been caught by insert_rule(). */
> > WARN_ON_ONCE(!id.key.object);
> > landlock_get_object(id.key.object);
> > }
>
> Thanks, I'll take it in my tree.
Thanks Mickael.
Regards,
Tanya
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-24 16:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-23 19:42 [PATCH] landlock: fix grammar and spelling error Tanya Agarwal
2025-01-24 9:24 ` Günther Noack
2025-01-24 11:36 ` Mickaël Salaün
2025-01-24 16:04 ` Tanya Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).