From: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
To: Paul Moore <paul@paul-moore.com>
Cc: linux-kernel@vger.kernel.org, "James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Pavel Begunkov" <asml.silence@gmail.com>,
"Stephen Smalley" <stephen.smalley.work@gmail.com>,
"Ondrej Mosnacek" <omosnace@redhat.com>,
"Bram Bonné" <brambonne@google.com>,
"Thiébaud Weksteen" <tweek@google.com>,
"Christian Göttsche" <cgzones@googlemail.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
linux-security-module@vger.kernel.org, io-uring@vger.kernel.org,
selinux@vger.kernel.org
Subject: Re: [PATCH v3 2/2] lsm,io_uring: add LSM hooks for io_uring_setup()
Date: Fri, 7 Feb 2025 16:53:21 -0500 [thread overview]
Message-ID: <Z6aA0cWte6rZQSbo@hm-sls2> (raw)
In-Reply-To: <a4541fab007858c599aed1d1e3e98883@paul-moore.com>
On Fri, Feb 07, 2025 at 04:42:57PM -0500, Paul Moore wrote:
> On Jan 27, 2025 Hamza Mahfooz <hamzamahfooz@linux.microsoft.com> wrote:
> >
> > It is desirable to allow LSM to configure accessibility to io_uring
> > because it is a coarse yet very simple way to restrict access to it. So,
> > add an LSM for io_uring_allowed() to guard access to io_uring.
> >
> > Cc: Paul Moore <paul@paul-moore.com>
> > Signed-off-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
> > ---
> > include/linux/lsm_hook_defs.h | 1 +
> > include/linux/security.h | 5 +++++
> > io_uring/io_uring.c | 2 +-
> > security/security.c | 12 ++++++++++++
> > security/selinux/hooks.c | 14 ++++++++++++++
> > security/selinux/include/classmap.h | 2 +-
> > 6 files changed, 34 insertions(+), 2 deletions(-)
>
> Thanks Hamza, this looks good to me, but we need to wait until we get an
> ACK from Jens on path 1/2; he's pretty responsive so I don't think we'll
> have to wait too long.
>
> As far as the return/label issue in patch 1/2, as long as there are no
> other issues, and you are okay with the change, I can fix that up when
> merging your patches.
Ya, that sounds good to me, thanks!
>
> --
> paul-moore.com
next prev parent reply other threads:[~2025-02-07 21:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 15:57 [PATCH v3 1/2] io_uring: refactor io_uring_allowed() Hamza Mahfooz
2025-01-27 15:57 ` [PATCH v3 2/2] lsm,io_uring: add LSM hooks for io_uring_setup() Hamza Mahfooz
2025-01-27 17:18 ` Casey Schaufler
2025-01-27 21:23 ` Paul Moore
2025-01-28 0:23 ` Casey Schaufler
2025-01-28 22:35 ` Paul Moore
2025-01-29 0:02 ` Casey Schaufler
2025-01-30 17:15 ` Paul Moore
2025-02-07 21:42 ` Paul Moore
2025-02-07 21:53 ` Hamza Mahfooz [this message]
2025-02-07 21:42 ` [PATCH v3 1/2] io_uring: refactor io_uring_allowed() Paul Moore
2025-02-07 21:54 ` Jens Axboe
2025-02-07 22:21 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6aA0cWte6rZQSbo@hm-sls2 \
--to=hamzamahfooz@linux.microsoft.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brambonne@google.com \
--cc=cgzones@googlemail.com \
--cc=io-uring@vger.kernel.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).