From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E83D288A5; Sat, 1 Mar 2025 02:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740794404; cv=none; b=VZVBfY3lu53L+FqLX2hIgi89YJ4wx6UwwjKyrEUp8vE2cZmJ/ZN4jumnY5gXA4RWMuVugdcXem1cKYvyaUeUs25/MfyWZ5pJOt7HnXeeQA3Ay0+4Wy1xetyaNDgGgNPW5JeGPtw4TgkOX5eJ8AMmGoW0n9YX5HLG8wQMK3kqsgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740794404; c=relaxed/simple; bh=tfCtY5NJ5BOE0sjZ7QUWMS4vQMbSN7d9BCF5Jk0nH2E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oPlRqmtMCKFB4feHfYDQDF4/xEVQcTuYgPMTwQX1I2jb+IiN47z94xzyk569KhJDp4uQmOzXG9QxZmwdqqoUgYVrBO6TPkPvbpzDdfn5rN+OwUjWR59v+7OU3TTgeRY+kkLmFwwn6tY444O6UF4+Qn1ip+CXM4FEPHkfX9ZcEQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k/7rVFOX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k/7rVFOX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06EB5C4CED6; Sat, 1 Mar 2025 02:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740794403; bh=tfCtY5NJ5BOE0sjZ7QUWMS4vQMbSN7d9BCF5Jk0nH2E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k/7rVFOX8vtqiNkIjCdVugpNQNe7eEURb4EocMuBmpL0q/3lIoEfQ7kreZotvXsrU AT/auXa1M9oSI0aBDncu+RAmlSTeRrb8mMEGYUMvFHacLvj5wB0BW8ybs6rtFyYYLP z8rmcr9UTxWn9TytVlWxZjqYWcwUQUiRfmxJD/Vh1xJCXvaA9BOquAx67stlIOt1Xd QdSg/iEPrLXwZ2GxxTGLbmUw/70I1rraRR1pAz99enq9SwgB0XTO/ncbAwJv3zgPeb iRcK/YCNMR1SQCtKQ8vOYboIlfZKnIsFKZwmSXbAtTmKLtOQpnIVPaiX+OS0oqhfQ4 6q4x8JO84PBVQ== Date: Sat, 1 Mar 2025 03:59:59 +0200 From: Jarkko Sakkinen To: Paul Moore Cc: "Ricardo B. Marliere" , David Howells , James Morris , "Serge E. Hallyn" , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Wei=DFschuh?= , "Ricardo B. Marliere" Subject: Re: [PATCH] security: keys: Make sysctl table const Message-ID: References: <20250123-sysctl_const-pcmoore-v1-1-d9f918dbb0be@suse.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Feb 26, 2025 at 07:21:39PM -0500, Paul Moore wrote: > On Thu, Jan 23, 2025 at 2:50 PM Ricardo B. Marliere > wrote: > > > > Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct > > ctl_table"), the sysctl registration API allows for struct ctl_table to be > > in read-only memory. Move key_sysctls to be declared at build time, instead > > of having to be dynamically allocated at boot time. > > > > Cc: Thomas Weißschuh > > Suggested-by: Thomas Weißschuh > > Signed-off-by: Ricardo B. Marliere > > --- > > security/keys/sysctl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Looks fine to me. David or Jarkko, this looks like something for the > keys tree, yes? > > Reviewed-by: Paul Moore I can pick this after back from holiday on next week. Reviewed-by: Jarkko Sakkinen BR, Jarkko