linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: sergeh@kernel.org
Cc: Paul Moore <paul@paul-moore.com>,
	serge@hallyn.com, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] capability: Remove unused has_capability
Date: Sat, 8 Mar 2025 12:29:09 +0000	[thread overview]
Message-ID: <Z8w4FWl03gHYggPp@gallifrey> (raw)
In-Reply-To: <Z8u9MhM450tD3lYe@lei>

* sergeh@kernel.org (sergeh@kernel.org) wrote:
> On Wed, Feb 26, 2025 at 07:08:52PM -0500, Paul Moore wrote:
> > On Thu, Dec 19, 2024 at 1:28 PM Paul Moore <paul@paul-moore.com> wrote:
> > >
> > > On Thu, Dec 19, 2024 at 12:29 PM <linux@treblig.org> wrote:
> > > >
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > >
> > > > The vanilla has_capability() function has been unused since 2018's
> > > > commit dcb569cf6ac9 ("Smack: ptrace capability use fixes")
> > > >
> > > > Remove it.
> > > >
> > > > Fixup a comment in security/commoncap.c that referenced it.
> > > >
> > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > > ---
> > > >  include/linux/capability.h |  5 -----
> > > >  kernel/capability.c        | 16 ----------------
> > > >  security/commoncap.c       |  9 +++++----
> > > >  3 files changed, 5 insertions(+), 25 deletions(-)
> > >
> > > Now that Serge has the capabilities tree back up and running I'm
> > > assuming he will grab this patch, if not just let me know Serge and I
> > > can take it.
> > >
> > > Reviewed-by: Paul Moore <paul@paul-moore.com>
> > 
> > Bump this thread to make sure Serge sees it ...
> 
> d'oh, sorry, yes
> 
> Acked-by: Serge Hallyn <serge@hallyn.com>
> 
> I will apply this now.

Thanks!

Dave

> -serge
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

      reply	other threads:[~2025-03-08 12:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 17:28 [PATCH v2] capability: Remove unused has_capability linux
2024-12-19 18:28 ` Paul Moore
2025-02-27  0:08   ` Paul Moore
2025-03-08  3:44     ` sergeh
2025-03-08 12:29       ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8w4FWl03gHYggPp@gallifrey \
    --to=linux@treblig.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=sergeh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).