From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: "Mirsad Goran Todorovac" <mirsad.goran.todorovac@alu.hr>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Paul Moore" <paul@paul-moore.com>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Christian Göttsche" <cgzones@googlemail.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Frederick Lawler" <fred@cloudflare.com>
Subject: Re: [PATCH v1 1/2] Add release hook to LSM
Date: Fri, 10 Mar 2023 22:12:38 +0200 [thread overview]
Message-ID: <ZAuPNm3UdC/c1EXm@smile.fi.intel.com> (raw)
In-Reply-To: <47129238-d98e-0561-0921-adfe40b6b85f@alu.unizg.hr>
On Fri, Mar 10, 2023 at 08:52:32PM +0100, Mirsad Goran Todorovac wrote:
> On 10. 03. 2023. 20:47, Andy Shevchenko wrote:
> > On Fri, Mar 10, 2023 at 08:42:00PM +0100, Mirsad Goran Todorovac wrote:
> >>
> >> Add release() hook to the definition of the LSM modules, to enable calling
> >> destructors and deallocating allocated resources cleanly.
> >>
> >> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> >
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > I haven't given you this tag. Sorry, you must not add something
> > which was not explicitly given.
>
> Mea culpa.
>
> I misunderstood that you have approved the change when saying that I should
> file a formal patch. It worked with Florian Westphal in my first patch, so I
> thought it would be inappropriate to leave out who endorsed the patch.
We have Suggested-by tag for that.
> Thousand apologies. This is my second patch, so I am asking for some extra
> grace ...
> What should I do now?
Wait at least a couple of days (even more, since it's weekend) for other
comments and then send a v2 of the series with the comments addressed.
Btw, you may take my "smart" script [1] for sending patch series. It
makes much less headache on how to do that properly.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-10 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 19:42 [PATCH v1 1/2] Add release hook to LSM Mirsad Goran Todorovac
2023-03-10 19:47 ` Andy Shevchenko
2023-03-10 19:52 ` Mirsad Goran Todorovac
2023-03-10 20:12 ` Andy Shevchenko [this message]
2023-03-10 20:46 ` Mirsad Goran Todorovac
2023-03-10 23:23 ` Mirsad Goran Todorovac
2023-03-10 20:02 ` Mirsad Goran Todorovac
2023-03-10 20:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAuPNm3UdC/c1EXm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=casey@schaufler-ca.com \
--cc=cgzones@googlemail.com \
--cc=fred@cloudflare.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mic@digikod.net \
--cc=mirsad.goran.todorovac@alu.hr \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=paul@paul-moore.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox