From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A39EE49A1 for ; Fri, 18 Aug 2023 23:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241796AbjHRXBv (ORCPT ); Fri, 18 Aug 2023 19:01:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241858AbjHRXBb (ORCPT ); Fri, 18 Aug 2023 19:01:31 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E57F421A for ; Fri, 18 Aug 2023 16:01:29 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d672f55d48dso1784234276.2 for ; Fri, 18 Aug 2023 16:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=gS9arkhq2BQM5wyG90faWG4pywmMu5sfjHEWd04bKy84agcqatheT6YSVqsnMAhJXs 7Ey6R/IsFpbuJAgflRTfCsGQSeE7z8aCnsHRbxEkKBK/PAH7FMZgZEavx3BeBXM+3P+2 Plq9VhZaRy5PbOx8EDNA03ytcClkYRB9Plt+OD+UltS53ZO5IOuVPHa/Yt8AOkDtjpGf J0ReekJEPtY7ifZaoOCUWVj24ZOCPfNYabKI/jnVy+VGWVTelTn6BvdxHdiQrBc+k/kc BoETN+5H+qyvqSzJ4nWEMxKRREF2ybV9p6gaBfB8lx1V/iAPfjWa3WjZDIbTKQp0bm0Z IJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=Roeo7SlhAF4/NujukHqVZE78zwtCxAfyoYMjg1H3kozZRdu3UB5NxQKWXCAu5OLQCf UXoBwH17r5qo6rk8w+HAmhVacRNc28BjJIplkO3iTsjstS5xYVfXSsRE794LacQsCej2 28EVXhFtoY4J69aan8vGAi/mseQMs/gWiXGA8XdqWy4bZRUlkKD7BDl8VIPTV/qeRBU0 hwUHq+U/Xtmihq1f+WgmNLi8ViRp+gJsIEHoRZL8xqYyRhEuXAfQ4WQ/fQetReSMQHsk VYrtszN5JM28WxJxwpiMu0wbW83MZ9l34T8uJuWGe2bfaZey+NDyd9UWUKmXytwRODuF F8yQ== X-Gm-Message-State: AOJu0YzWXg1uhpEeN2Zr6L0b39dQMvvxNFO7+sa4cdLrvH1uXkSK4Tjl Zyh8TL77TobwxzZFGOFZjzc9gz5v2ag= X-Google-Smtp-Source: AGHT+IHoaUgHi5iMS/0Xt5cvUarFzMCVBDWHJfa8lAvVIAai8wyXyMLBOgyLMJxxiXlZfzlnoz9PoDeIZVI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:a8a:b0:d74:347:1e3 with SMTP id cd10-20020a0569020a8a00b00d74034701e3mr5755ybb.9.1692399688376; Fri, 18 Aug 2023 16:01:28 -0700 (PDT) Date: Fri, 18 Aug 2023 16:01:26 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230718234512.1690985-29-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() From: Sean Christopherson To: Ackerley Tng Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, willy@infradead.org, akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, yu.c.zhang@linux.intel.com, vannapurve@google.com, mail@maciej.szmigiero.name, vbabka@suse.cz, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: On Mon, Aug 07, 2023, Ackerley Tng wrote: > Sean Christopherson writes: > > > Add a selftest to verify the basic functionality of guest_memfd(): > > > > > > Here's one more test: First off, thank you! I greatly appreciate all the selftests work you (and others!) have been doing. For v2, can you please post a standalone patch? My workflow barfs on unrelated, inlined patches. I'm guessing I can get b4 to play nice, but it's easier to just yell at people :-) > >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 > From: Ackerley Tng > Date: Tue, 1 Aug 2023 18:02:50 +0000 > Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for > KVM_CREATE_GUEST_MEMFD > > Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as > non-page-aligned page size and invalid flags, are rejected by the > KVM_CREATE_GUEST_MEMFD with EINVAL > > Signed-off-by: Ackerley Tng > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ > .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index eb93c608a7e0..ad20f11b2d2c 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) > TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); > } > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) > +{ > + int fd; > + > + /* Non-page-aligned page_size */ Instead of adding a comment, use the message from TEST_ASSERT() to communicate that information to the reader *and* to anyone that encounters failures. > + fd = __vm_create_guest_memfd(vm, 1, 0); ioctls() are fast. Rather than hardcode one value, iterate over a range of values, e.g. for (size = 0; size < page_size; size++) { r = __vm_create_guest_memfd(vm, size, 0); TEST_ASSERT(r && errno == EINVAL, "Informative error message...); } > + ASSERT_EQ(errno, EINVAL); > + > + /* Invalid flags */ > + fd = __vm_create_guest_memfd(vm, page_size, 99); > + ASSERT_EQ(fd, -1); > + ASSERT_EQ(errno, EINVAL); And then same thing here. Then you can use the legal flags to determine what is and isn't valid, instead of using a completely arbitrary magic number.