From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0FEC15FCFE for ; Fri, 21 Jun 2024 16:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718987972; cv=none; b=qkai3AOPNq/Pu2mgxlmlGw5X8NuknbyrQF+mjWIBTYFoVm7F2hpyiFLL3/WEtMeR62e7Y8AlkkYuNKLw30rMxqTsnGnYG64CzKvSzjeMxO8jnxvLrRsl9cvpaMahtmVkEg9yoXlsUgVoY6fNc1vlFQ6QthqsWcACOrQGRTkiVwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718987972; c=relaxed/simple; bh=UlgFUywd2WSEjSU6xsxYFHFG7CT7Xep9ROempUMO7/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L6tI1ZnQPoodqL34jSzyreYQmkGGvyciJdsZ7kg5PStLE62dVfwp3rLT5kxFTZf2XEX6/cUVhTTwndabgAx3Ux4XoiqpGZf/s0cwQ12Q514KaThb60oCmYl2s/09S1wEbflmFksXuHNZ2ZjgQoPKqit9XktDH6jwndM8yA/DFhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=VtXeSSY9; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="VtXeSSY9" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ebd6ae2f56so2920631fa.0 for ; Fri, 21 Jun 2024 09:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1718987969; x=1719592769; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=d+B4q6j7rnOa8lY5YGMu4l7DUBInPDPw5kUdlNxco7g=; b=VtXeSSY9ptdv08DJDTJ2WKmFOBfvm36uqqpB1SXvyXSjnyBwyR/YSRClM3Fekc5PEb dd8gQNWD9nZJ9TDZN2xK7sOY6Ng+93H+bPR3vwYwyztHQIRZ7VsPi0IMubPX9azpw0gj 56RGX+N8Cg63P3IsX1jP8xeP/0Sw8vR5VG9e8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718987969; x=1719592769; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d+B4q6j7rnOa8lY5YGMu4l7DUBInPDPw5kUdlNxco7g=; b=Y1PvTQ0ZSVAurrSVcEVZ82L8bmTBhucBi9igv+ckFk0EdgSyPY3YgfjTaNv0jPXEc/ nN3T2A3INzroqvxTWzkuAn2ts5+Zv3JOmOoAeq3JMh5kUN71Tnmopi8rHWjaYUsrPRsm eRYqWYA4zN9i1qFnjXZ2/brM6mWjY8OfkfaMNYoAMsf0VFGAS6IUIbd7FgxnVqA+Ungy TifNYPi9w6zx0v0orC7m6YX6qNukWMkNlPms2G2eiWnwhRr6licjapZGUPgO/UgIZRIv Q/dDwgQJJEvwoOr5FDLTY8IU9xOdi7pK6pctYPV1pq3GFXj8krrnHEJZNz5z1XMZcQmO 341w== X-Forwarded-Encrypted: i=1; AJvYcCWp7lydXqF+g5XGxK+TGy4twLe+MrHMg57HIMj4p6HjTaBXxbPbuyaeoYynGkOXrw3JlJ8aYj3v/yCrjeTudOkEgzbiY5f/KVsp9iFKip6mAoYKrmvT X-Gm-Message-State: AOJu0YwJ0veafTrwXOxEuS2D4dcvEZLp7VbHIb0P+h/Y5Iwb+KZoiSFb MTgIgH0s7opw6tw0EpZMyouJpu1AAXcm/zxq7w4IXu6XTae7N3JTUWsh6i/CMcM= X-Google-Smtp-Source: AGHT+IG0ddJjXBlSpbVZD4r9/H9u00KEsN82L79oP/i1sXbnFlr8kZL72WUFKn7R6WiFRcw1OhTvRw== X-Received: by 2002:a05:651c:1a12:b0:2ec:5365:34d3 with SMTP id 38308e7fff4ca-2ec53653746mr3909701fa.1.1718987968916; Fri, 21 Jun 2024 09:39:28 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663a8c8960sm2247234f8f.100.2024.06.21.09.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 09:39:28 -0700 (PDT) Date: Fri, 21 Jun 2024 18:39:26 +0200 From: Daniel Vetter To: Yafang Shao Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: Re: [PATCH v3 11/11] drm: Replace strcpy() with __get_task_comm() Message-ID: Mail-Followup-To: Yafang Shao , torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie References: <20240621022959.9124-1-laoar.shao@gmail.com> <20240621022959.9124-12-laoar.shao@gmail.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621022959.9124-12-laoar.shao@gmail.com> X-Operating-System: Linux phenom 6.8.9-amd64 On Fri, Jun 21, 2024 at 10:29:59AM +0800, Yafang Shao wrote: > To prevent erros from occurring when the src string is longer than the > dst string in strcpy(), we should use __get_task_comm() instead. This > approach also facilitates future extensions to the task comm. > > Signed-off-by: Yafang Shao > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter I guess the entire series will go in through a dedicated pull or some other tree, so Acked-by: Daniel Vetter for merging through whatever non-drm tree makes most sense for this. Cheers, Sima > --- > drivers/gpu/drm/drm_framebuffer.c | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c > index 888aadb6a4ac..25262b07ffaf 100644 > --- a/drivers/gpu/drm/drm_framebuffer.c > +++ b/drivers/gpu/drm/drm_framebuffer.c > @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, > INIT_LIST_HEAD(&fb->filp_head); > > fb->funcs = funcs; > - strcpy(fb->comm, current->comm); > + __get_task_comm(fb->comm, sizeof(fb->comm), current); > > ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB, > false, drm_framebuffer_free); > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 625b3c024540..b2c16a53bd24 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1411,7 +1411,7 @@ static bool record_context(struct i915_gem_context_coredump *e, > rcu_read_lock(); > task = pid_task(ctx->pid, PIDTYPE_PID); > if (task) { > - strcpy(e->comm, task->comm); > + __get_task_comm(e->comm, sizeof(e->comm), task); > e->pid = task->pid; > } > rcu_read_unlock(); > -- > 2.39.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch