From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646995381E; Fri, 11 Oct 2024 15:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728660879; cv=none; b=JQPwObNRVNokL3VuvEd6a5EgnpNljFVCJoPktsYOz9cMj280VMS+bIrfwOvrdnouoForXpIz/eyM+np3PGvEF8TfjtMUYp0cbWcYPof7dyRqQXUGQwCvZ+Sz+fSzvQ3K4j6s/CRToCL2IH3oryCtlYDk+paXJ+TsqruA0z9BXNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728660879; c=relaxed/simple; bh=dtcs1yN4pz+Zbu8KHjgOTEMBUEC8VG9TJOw5rXp6cgg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ri+hM9AXqYevIV5mWZGvDG3U77vdhDxOpX6AnwzBvkJ/fmPeJDiqHAcSkwQa7IYL8rIZPyfFuYF+7asMIIZazF7iRvZnFtQQHBYUrt55bG5W7oZp4dkkHHcikL6tSfpkh44vhzi3UPkD1aF+6+7HNfR7iAkIEQYsa7VCLW3SjL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=lLgYVWvw; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lLgYVWvw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=V5IK78oxLAcUke4+8ve0ylm+nCiIdwlDSu6wnFwD3fQ=; b=lLgYVWvwIbQuKavphrC2s+Zo+a yp6uiYGdPJKOvLMrF5lWNo1w3tIe8Tk1cy0z9jURe4qUe6LYYqYMqiIu/8bq6IdvqxXYSYC/5daPe xdiYL44Y1hUfz2NRhrYeI0xR7J9mNvDd7hQFfdbJf03e/7xBay/CEwa1JgRysSJ2W/jnWYVzVDMSF ptG2V3fl9oUNjfEn0piSuHpqk6j3821IdiKpc7xp71S+PQrkS6pzP6Ial1cHTLiT+ypVd1Fr7ksxh Nk4hYnt3IanT0tE4DMGGkvynCqFwc37lQPI2sgfyZ51VciibVmrGbbGl57qrDup+/u0oCk78P31Jd mvyCLsHg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1szHf1-0000000Goqs-2W9z; Fri, 11 Oct 2024 15:34:35 +0000 Date: Fri, 11 Oct 2024 08:34:35 -0700 From: Christoph Hellwig To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Christoph Hellwig , Christian Brauner , Paul Moore , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-security-module@vger.kernel.org, audit@vger.kernel.org, Trond Myklebust , Anna Schumaker , Alexander Viro , Jan Kara Subject: Re: [RFC PATCH v1 1/7] fs: Add inode_get_ino() and implement get_ino() for NFS Message-ID: References: <20241010152649.849254-1-mic@digikod.net> <20241011.ieghie3Aiye4@digikod.net> <20241011.yai6KiDa7ieg@digikod.net> <20241011.aetou9haeCah@digikod.net> <20241011.uu1Bieghaiwu@digikod.net> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241011.uu1Bieghaiwu@digikod.net> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Fri, Oct 11, 2024 at 05:30:59PM +0200, Mickaël Salaün wrote: > > It still is useless. E.g. btrfs has duplicate inode numbers due to > > subvolumes. > > At least it reflects what users see. Users generally don't see inode numbers. > > If you want a better pretty but not useful value just work on making > > i_ino 64-bits wide, which is long overdue. > > That would require too much work for me, and this would be a pain to > backport to all stable kernels. Well, if doing the right thing is too hard we can easily do nothing. In case it wan't clear, this thread has been a very explicit: Reviewed-by: Christoph Hellwig