From: "Günther Noack" <gnoack@google.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: Mikhail Ivanov <ivanov.mikhail1@huawei-partners.com>,
Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
Paul Moore <paul@paul-moore.com>,
Tahera Fahimi <fahimitahera@gmail.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v4 1/3] landlock: Refactor filesystem access mask management
Date: Sat, 9 Nov 2024 19:36:23 +0100 [thread overview]
Message-ID: <Zy-rpxay3VmM7QuG@google.com> (raw)
In-Reply-To: <20241109.xie6Quae9chi@digikod.net>
On Sat, Nov 09, 2024 at 12:14:49PM +0100, Mickaël Salaün wrote:
> On Sat, Nov 09, 2024 at 12:08:54PM +0100, Mickaël Salaün wrote:
> > Replace get_raw_handled_fs_accesses() with a generic
> > landlock_merge_access_masks(), and replace get_fs_domain() with a
> > generic landlock_match_ruleset(). These helpers will also be useful for
> > other types of access.
>
> Of course I need to update the commit messages with the new names...
Yes, those are still using the old function names.
At this point my other two remaining remarks are so minor,
I think we can skip another version of this patch set. 👍
Thanks for simplifying the code!
—Günther
next prev parent reply other threads:[~2024-11-09 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 11:08 [PATCH v4 0/3] Refactor Landlock access mask management Mickaël Salaün
2024-11-09 11:08 ` [PATCH v4 1/3] landlock: Refactor filesystem " Mickaël Salaün
2024-11-09 11:14 ` Mickaël Salaün
2024-11-09 18:36 ` Günther Noack [this message]
2024-11-09 18:21 ` Günther Noack
2024-11-09 11:08 ` [PATCH v4 2/3] landlock: Refactor network " Mickaël Salaün
2024-11-09 18:23 ` Günther Noack
2024-11-09 11:08 ` [PATCH v4 3/3] landlock: Optimize scope enforcement Mickaël Salaün
2024-11-09 18:30 ` Günther Noack
2024-11-09 18:47 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy-rpxay3VmM7QuG@google.com \
--to=gnoack@google.com \
--cc=fahimitahera@gmail.com \
--cc=ivanov.mikhail1@huawei-partners.com \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).