From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C0EC83005 for ; Mon, 12 Jun 2023 10:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235436AbjFLKwX (ORCPT ); Mon, 12 Jun 2023 06:52:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbjFLKvz (ORCPT ); Mon, 12 Jun 2023 06:51:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01B993FF; Mon, 12 Jun 2023 03:36:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A808C614F0; Mon, 12 Jun 2023 10:36:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10C3AC4339C; Mon, 12 Jun 2023 10:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566191; bh=7lfE8n4wCuge2Ilsu3h1F4ipyzhUj7bSJuflx8EXZtw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=DU0ZjjsJO4rS5B/LrOhkcDtfvbBZTjXhclQjcMb8L0SMAJ/Zj8o6cOouP0LPA9kRi VqJ/momrCYS9bgBfSwuBqZwMMGlKax5OQGCSRTBF7m/eO1OCct4ECh1Dq3q51n5hhV Yhf0l7cjjbGMIJ2UYDeBi6gwKGFHv0g6f2BclJ5kTS9KJF0zsyYQaetziIibzJHykN 7tP2iy40SDcuxMKwZA7N7Mbn26TeBSys37uMErgDMUpaf6wBIfwFsLid/c78sbMh0z WHZh5yV0lSHcOPaWQW6a50hTCYgYFvBa4rOsjTJ1iVF0vlDpRO8qNBXUJAB1ctdV+d JMJSCsxLTJnJg== Message-ID: Subject: Re: [PATCH 7/9] gfs2: update ctime when quota is updated From: Jeff Layton To: Andreas Gruenbacher Cc: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Bob Peterson , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Suren Baghdasaryan , Sebastian Reichel , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Date: Mon, 12 Jun 2023 06:36:26 -0400 In-Reply-To: References: <20230609125023.399942-1-jlayton@kernel.org> <20230609125023.399942-8-jlayton@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: On Fri, 2023-06-09 at 18:44 +0200, Andreas Gruenbacher wrote: > Jeff, >=20 > On Fri, Jun 9, 2023 at 2:50=E2=80=AFPM Jeff Layton w= rote: > > Signed-off-by: Jeff Layton > > --- > > fs/gfs2/quota.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c > > index 1ed17226d9ed..6d283e071b90 100644 > > --- a/fs/gfs2/quota.c > > +++ b/fs/gfs2/quota.c > > @@ -869,7 +869,7 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip,= loff_t loc, > > size =3D loc + sizeof(struct gfs2_quota); > > if (size > inode->i_size) > > i_size_write(inode, size); > > - inode->i_mtime =3D inode->i_atime =3D current_time(inod= e); > > + inode->i_mtime =3D inode->i_atime =3D inode->i_ctime = =3D current_time(inode); >=20 > I don't think we need to worry about the ctime of the quota inode as > that inode is internal to the filesystem only. >=20 Thanks Andreas. I'll plan to drop this patch from the series for now. Does updating the mtime and atime here serve any purpose, or should those also be removed? If you plan to keep the a/mtime updates then I'd still suggest updating the ctime for consistency's sake. It shouldn't cost anything extra to do so since you're dirtying the inode below anyway. Thanks! > > mark_inode_dirty(inode); > > set_bit(QDF_REFRESH, &qd->qd_flags); > > } > > -- > > 2.40.1 > >=20 >=20 > Thanks, > Andreas >=20 --=20 Jeff Layton