From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 765C91EF12 for ; Thu, 16 May 2024 18:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715882753; cv=none; b=oPFs2BN/LxlgGH4im9JR3KjTUW6gEQ2uja8Ewg6dUK3KsNF8IHYv7AuXAqacukxeBkGTceTjb9YV8ckhvI3qFlfPc9M1jgoritsbEpiJznRlEUvb/8L2cDvEADASpPXEnvUPTEPX8LnLPh64QYdGjgKrnWj1f45HfxlhhThv7xU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715882753; c=relaxed/simple; bh=bpIGieCWHFwLBK3L/EX06rJ2q6xGlvWxG1zJZRSm8AU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r/d70ljwd66F9N8R/Aou4Dl3yAUQ04TLMlQSHrlGLb2hB1PawSrA+95fT/cFZDnxYJwfpRsXgmH4/hpfoVsE1p8OEQq5vBK009Gn+2aJxY93H1+lp6uzjU9J+tpCHKumHojLNtu6WbnFcDtLhPBM6zhDxstYch+wK9r52aYHsYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VgNyG1sT; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VgNyG1sT" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7e1b8718926so9579939f.2 for ; Thu, 16 May 2024 11:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715882751; x=1716487551; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4kOPvncac5GEXKOWcgYcErTg+ZSoHGXXhbSEbOdfWFY=; b=VgNyG1sTGMPbFbGEZKKm0BQEExOc/DNgXJq81iCuCYAO9s7Q9cP72ZtoWvC4aSfnbk miVNgeUqXxb/GBDjmDX3wOYroGxWriSqloQQXiVubo/OkjQN3Fvr3Ecuqkqt0+81DLib DMWvaMvyxLVdD2GHV1v3GM5QDV5DS4E5nVIRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715882751; x=1716487551; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4kOPvncac5GEXKOWcgYcErTg+ZSoHGXXhbSEbOdfWFY=; b=RucJ4EseBeZpztPEbSfCqv6SpoZk5uAkDZR/gJvGhqDt2JJwjgV1x0ZnZT+pS3uIiW pKvBRnuRTkGqzK0LKz+lwPgZYyzc4alOaOt83BzIsdwEFP/cpfe4/+9oJIF0KgaFCAKR eXkAfyw+8nXwpO34sqp3KFsuvcg5LymS8ScYsZZq3RE02RWAq8PLLW0rn8cuXTBM5D3v j0EFY4IbPCM0KqXl0gAzR9UQwGgIPJDcPGjm0Zw7rlDl8EWRgqIsUoz6oocZdQBlOYF9 /sbE17N7MsZxoSLk4rjM32CiAYjW2WRjCjWI3XnX+kLJvjnppIroh0K4FITDR8Lj5Vuw e1XQ== X-Forwarded-Encrypted: i=1; AJvYcCXrDkcCtz4SbexmGGr8oypPH5vWQnnLTwOCBHIkDIn4NDN6vqitEZWZbEAFZj2E5/ezupkXFCoA/0ltZRwQEF4OmhKsOtawdwaz9XIduafUbFAWHMAC X-Gm-Message-State: AOJu0Yyq5ELcDLy5hxE2uDrXh1SZRxAqrC9AUYIZ/5NCL/h8tSpZQFpG aq+6LDpaFAh0Zovj8CLI4hwRE2/AzK5Chbaqvkt7cz4B04ScmBXBXfeNprBRs4s= X-Google-Smtp-Source: AGHT+IG9thpIuxuOJl/ateMI7c9MGpJjRHArmdLOc92/CkQSwD6jAwuSSMxSGmhDOz36YwjGKp1fTQ== X-Received: by 2002:a6b:d203:0:b0:7de:e04b:42c3 with SMTP id ca18e2360f4ac-7e1b5022577mr2055903739f.0.1715882751618; Thu, 16 May 2024 11:05:51 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-7e2031b57bcsm134683339f.8.2024.05.16.11.05.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 11:05:51 -0700 (PDT) Message-ID: Date: Thu, 16 May 2024 12:05:48 -0600 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE To: Tejun Heo Cc: Edward Liaw , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Zefan Li , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , Shakeel Butt , Yosry Ahmed , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Shuah Khan References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-9-edliaw@google.com> <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/16/24 11:45, Tejun Heo wrote: > Hello, > > On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: >> I am exploring options and leaning towards reverting the patch >> >> daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") >> >> Your amending the PR helps me if I have to send revert. I am sorry >> for the trouble. >> >> I can all of them together in a second update or after the merge window >> closes. > > The cgroup commit is already pulled in unfortunately. Can you please handle > the revert and whatever's necessary to fix up the situation? I'll ask you > what to do with selftest patches from now on. > Thanks for the update. Yes I am working on fixing the situation and will send revert for cgroup test patch as well if necessary. No worries. It is not a problem for you to handle cgroup test patches in general. I will need your review anyway and letting you handle them reduces the overhead. This kind of framework change causes needs to be coordinated. I should have held back on the framework change on my part. thanks, -- Shuah