From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6935C4649C for ; Fri, 5 Jul 2019 11:17:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0505218BC for ; Fri, 5 Jul 2019 11:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbfGELRH (ORCPT ); Fri, 5 Jul 2019 07:17:07 -0400 Received: from mga06.intel.com ([134.134.136.31]:51990 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbfGELRG (ORCPT ); Fri, 5 Jul 2019 07:17:06 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2019 04:17:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,454,1557212400"; d="scan'208";a="339808382" Received: from jsakkine-mobl1.tm.intel.com ([10.237.50.189]) by orsmga005.jf.intel.com with ESMTP; 05 Jul 2019 04:16:59 -0700 Message-ID: Subject: Re: [PATCH] Revert "tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()" From: Jarkko Sakkinen To: Mimi Zohar , Roberto Sassu , Michal Suchanek , linux-integrity@vger.kernel.org Cc: Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , James Bottomley , David Howells , Tomas Winkler , Armijn Hemel , Stefan Berger , Jerry Snitselaar , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Date: Fri, 05 Jul 2019 14:16:58 +0300 In-Reply-To: <1562240882.6165.78.camel@linux.ibm.com> References: <20190701131505.17759-1-msuchanek@suse.de> <8e4cc105b748c5395132b4d3d29d0d9b30a8720c.camel@linux.intel.com> <1562240882.6165.78.camel@linux.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Thu, 2019-07-04 at 07:48 -0400, Mimi Zohar wrote: > On Thu, 2019-07-04 at 13:28 +0200, Roberto Sassu wrote: > > On 7/4/2019 12:03 PM, Jarkko Sakkinen wrote: > > > On Mon, 2019-07-01 at 15:15 +0200, Michal Suchanek wrote: > > > > This reverts commit 0b6cf6b97b7ef1fa3c7fefab0cac897a1c4a3400 to avoid > > > > following crash: > > > > > > Thank you. I think this the right choice for the moment. I fixed > > > a trivial checkpatch.pl error and added the mandatory tags. Can > > > you check quickly v2 (just posted)? > > > > > > I already made it available in my master and next. > > > > Could you please wait few days? I would prefer to fix this issue instead > > of reverting the whole patch. > > Nayna posted a patch late yesterday titled "tpm: fixes uninitialized > allocated banks for IBM vtpm driver", which addresses this bug. With some minor changes it should be fine. /Jarkko