linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: sergeh@kernel.org
To: Yue Haibing <yuehaibing@huawei.com>
Cc: paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
	casey@schaufler-ca.com, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] security: Remove unused declaration cap_mmap_file()
Date: Tue, 24 Jun 2025 12:27:50 +0000	[thread overview]
Message-ID: <aFqZxu_Slzmux6jj@lei> (raw)
In-Reply-To: <20250624014108.3686460-1-yuehaibing@huawei.com>

On Tue, Jun 24, 2025 at 09:41:08AM +0800, Yue Haibing wrote:
> Commit 3f4f1f8a1ab7 ("capabilities: remove cap_mmap_file()")
> removed the implementation but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Hm, how did I not catch that?  Thanks.

Reviewed-by: Serge Hallyn <serge@hallyn.com>

> ---
>  include/linux/security.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/security.h b/include/linux/security.h
> index dba349629229..e8d9f6069f0c 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -193,8 +193,6 @@ int cap_inode_getsecurity(struct mnt_idmap *idmap,
>  			  struct inode *inode, const char *name, void **buffer,
>  			  bool alloc);
>  extern int cap_mmap_addr(unsigned long addr);
> -extern int cap_mmap_file(struct file *file, unsigned long reqprot,
> -			 unsigned long prot, unsigned long flags);
>  extern int cap_task_fix_setuid(struct cred *new, const struct cred *old, int flags);
>  extern int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3,
>  			  unsigned long arg4, unsigned long arg5);
> -- 
> 2.34.1
> 

  reply	other threads:[~2025-06-24 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24  1:41 [PATCH -next] security: Remove unused declaration cap_mmap_file() Yue Haibing
2025-06-24 12:27 ` sergeh [this message]
2025-06-24 15:48   ` Paul Moore
2025-06-24 20:46     ` Serge E. Hallyn
2025-06-24 23:32 ` [PATCH] " Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFqZxu_Slzmux6jj@lei \
    --to=sergeh@kernel.org \
    --cc=casey@schaufler-ca.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).