From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1971E81732 for ; Fri, 22 Aug 2025 01:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755825712; cv=none; b=d/1Kwj5aEKmsOefrJOblN4nz9sr8eKXOpVJB2+CNB9poQR1KEfbPxs//ka2bS+3o5QEQfl5Oiccm/aK1rb9T5BHnZN0dEjCX/baXeymNo2AjC5ypVmqQ48dAdjuj1Gj3U0B9hZC+x3ciilPplVY5InbUUoKEfP8UlKKHpptJqO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755825712; c=relaxed/simple; bh=ntCiTsnHyv89Ppw/YN8mIQ+gYRwhLO3TxI+GVHhT5J0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QoDvgKdQqUToHUXSbb2Ajw3IDowK92S9PE5eNKQYLckyY91NFqNFNdHGmi5Ct4AxN/9kI1MqsWVry9QBJA2X2WTt1iMQL43m8UNUYwziHcqu6qxXc0KmhTaANcqEorgrWSxnQ2xndqWtink1o8bKV0wN0ctox7oPWEhMOD2KMQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TBC9VFsI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TBC9VFsI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755825709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pP1gIuRFr7tSKsLKFv1sUFXkEDX22rWdnjLkvx8Dr3w=; b=TBC9VFsIYYI69t11+qEremjNYHAayz0i9osAj5Q2dY4TwAfM1k9rEbkHT1QQJcWqjvB7aB X+iF6KXG3GkzPXvT1c5kpa8CGnoCp2aM/KhPrdCa2CQninAFotHYOb7Py51jHK2AicxBnM CHrcw3CKc/5NY4NrV0yTl1HIiZtrhp8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-NdzZ7o2eMMy-971uUgmbKA-1; Thu, 21 Aug 2025 21:21:47 -0400 X-MC-Unique: NdzZ7o2eMMy-971uUgmbKA-1 X-Mimecast-MFC-AGG-ID: NdzZ7o2eMMy-971uUgmbKA_1755825704 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5BF62180035C; Fri, 22 Aug 2025 01:21:43 +0000 (UTC) Received: from fedora (unknown [10.72.116.34]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 18ED9180028F; Fri, 22 Aug 2025 01:21:29 +0000 (UTC) Date: Fri, 22 Aug 2025 09:21:24 +0800 From: Ming Lei To: Bala-Vignesh-Reddy Cc: akpm@linux-foundation.org, shuah@kernel.org, mic@digikod.net, gnoack@google.com, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, skhan@linuxfoundation.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] selftests: centralise maybe-unused definition in kselftest.h Message-ID: References: <20250821101159.2238-1-reddybalavignesh9979@gmail.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250821101159.2238-1-reddybalavignesh9979@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Thu, Aug 21, 2025 at 03:41:59PM +0530, Bala-Vignesh-Reddy wrote: > Several selftests subdirectories duplicated the define __maybe_unused, > leading to redundant code. Moved to kselftest.h header and removed > other definition. > > This addresses the duplication noted in the proc-pid-vm warning fix > > Suggested-by: Andrew Morton > Link:https://lore.kernel.org/lkml/20250820143954.33d95635e504e94df01930d0@linux-foundation.org/ > > Signed-off-by: Bala-Vignesh-Reddy Reviewed-by: Ming Lei Thanks, Ming