From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31CAE305E33; Mon, 22 Sep 2025 17:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758561739; cv=none; b=R6e8Fhqgz1JYQ1glEZhl56Av1EFlbWCd0xkkqEldMivUHtfqzJUsXNGJG4xbkyvh9QKzwKdsBCOOqLf83gvE4itVv+/nUOOSmtC8OAD/SpsPk4XZa3bai0cpjcUNjpc4EzVZ83/n9peB/V905aPOyHpq50Z0H8zGPo4/MYB0N+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758561739; c=relaxed/simple; bh=VN0yMScQ8pb/61s20XjaSKiW9Mzun4YWkxHCUCwd0Gc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BOR4YY7YppoVDp0EWEfk4fPx9BafX04JjTS3HZkkhB66bx/Z/OGMrX5WD1lkaHRYeh+1KNgVmbmvIv+bcP80iithPyW2tELdAd10p+qAmYfpNZgESuWHA1DaBH34x7lIqho2M9kJZvxDDzj2S82SlykWKGEr1vyB4X2c5XcfWOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=benboeckel.net; spf=pass smtp.mailfrom=benboeckel.net; dkim=pass (2048-bit key) header.d=benboeckel.net header.i=@benboeckel.net header.b=dspsx8At; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=DkOyr9XC; arc=none smtp.client-ip=202.12.124.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=benboeckel.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=benboeckel.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=benboeckel.net header.i=@benboeckel.net header.b="dspsx8At"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="DkOyr9XC" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id BD0261D00232; Mon, 22 Sep 2025 13:22:15 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Mon, 22 Sep 2025 13:22:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benboeckel.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to; s=fm3; t=1758561735; x=1758648135; bh=K8LjtBRRLWLzn/Sx28Fp4ytkbkynjN1owR8vzMqVA6E=; b= dspsx8AtAyFXyefXTGJ4sjqIyY4LfhNOU+EEYgr+OmVPdxz+xaEfcoeBds6hURwo tnCCMDWmhkyuOhKHKq2kPpJlknzTVJdBSHDrSwAFLnzeXlpthVyDRYKMknHSdltm olRsCg++XOH6ocGn8NSJCTQNGY9Z0t+S5Uj22iYCyJp+X/IfGL/i7UfZisuR+g7L YRmVI4BgjaIip6oQAitSU8SPjNVBBUWGxZlTIlHu5lu3x7PgbRSVoq2UI8HJviXc 6SQHx0t79b6R0xZ6ZSUD05/VRhLFFLz4woqymB+hqmbHOTyStEIvCFOl7aDKdKNn vq0tfkSUtNYNrPxSkISEIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1758561735; x=1758648135; bh=K8LjtBRRLWLzn/Sx28Fp4ytkbkyn jN1owR8vzMqVA6E=; b=DkOyr9XCnn2hEyg4t2q2lgLtX0SZl21VY3bNu2KxCLrm KX8cu3HobsPNkvexCMBTSNFKfkOsvTlHjMrsz3xl/csH86RIsTpvbpV/t1kGAnep pwTlOJSBM4iu+m6a158InW/B6LK9SA3HBdsXEKWmb3evSiW4lrma0dpdx+1gOCDC Y92kwzEqGzLf40sWoNFKw7GUqwIPDE5sw/o4g8MQ3zBMciA46hLCbtXDC2lHmBG+ R3yHdhCk6ZU8yo1I8dwS5kVcs+2A+aBGFa1bF4PJSNsN/FJ4pfZ5mATcPCr2BgRP Lo5OsnjEAB5n9mxccvpP8siONFEbvxC/ac42zRmz+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdehkeeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhrfhggtggujggfsehttdertddtreejnecuhfhrohhmpeeuvghnuceu ohgvtghkvghluceomhgvsegsvghnsghovggtkhgvlhdrnhgvtheqnecuggftrfgrthhtvg hrnhepudethefgfeduffefleffhfehjefgvdffhfelvdeukeduueeigeeujeeiffdvieeg necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgvse gsvghnsghovggtkhgvlhdrnhgvthdpnhgspghrtghpthhtohepudegpdhmohguvgepshhm thhpohhuthdprhgtphhtthhopehjrghrkhhkoheskhgvrhhnvghlrdhorhhgpdhrtghpth htoheplhhinhhugidqihhnthgvghhrihhthiesvhhgvghrrdhkvghrnhgvlhdrohhrghdp rhgtphhtthhopehjrghrkhhkohdrshgrkhhkihhnvghnsehophhinhhshihsrdgtohhmpd hrtghpthhtohepphgvthgvrhhhuhgvfigvsehgmhigrdguvgdprhgtphhtthhopehjghhg seiiihgvphgvrdgtrgdprhgtphhtthhopeguhhhofigvlhhlshesrhgvughhrghtrdgtoh hmpdhrtghpthhtohepphgruhhlsehprghulhdqmhhoohhrvgdrtghomhdprhgtphhtthho pehjmhhorhhrihhssehnrghmvghirdhorhhgpdhrtghpthhtohepshgvrhhgvgeshhgrlh hlhihnrdgtohhm X-ME-Proxy: Feedback-ID: iffc1478b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Sep 2025 13:22:14 -0400 (EDT) Date: Mon, 22 Sep 2025 13:22:13 -0400 From: Ben Boeckel To: Jarkko Sakkinen Cc: linux-integrity@vger.kernel.org, Jarkko Sakkinen , Peter Huewe , Jason Gunthorpe , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" , James Bottomley , Mimi Zohar , open list , "open list:KEYS/KEYRINGS" , "open list:SECURITY SUBSYSTEM" Subject: Re: [PATCH 3/4] tpm2-sessions: Remove unnecessary wrapper Message-ID: Reply-To: list.lkml.keyrings@me.benboeckel.net References: <20250922164318.3540792-1-jarkko@kernel.org> <20250922164318.3540792-4-jarkko@kernel.org> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250922164318.3540792-4-jarkko@kernel.org> User-Agent: Mutt/2.2.14 (2025-02-20) On Mon, Sep 22, 2025 at 19:43:16 +0300, Jarkko Sakkinen wrote: > From: Jarkko Sakkinen > > Open code tpm_buf_append_hmac_session_opt() because it adds unnecessary > disperancy to the call sites (and reduces the amount of code). ^^^^^^^^^^ "discrepancy" as in "difference"? But that doesn't feel like the right usage either. Perhaps "unnecessary abstraction"? Also, open coding it reduces the amount of code, so some clarification to not read as something else that "it" (`tpm_buf_append_hmac_session_opt`) does would be clearer. Thanks, --Ben