From: Jarkko Sakkinen <jarkko@kernel.org>
To: linux-integrity@vger.kernel.org
Cc: Stefano Garzarella <sgarzare@redhat.com>,
David Howells <dhowells@redhat.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"open list:KEYS/KEYRINGS" <keyrings@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 0/3] tpm: robust stack allocations
Date: Wed, 24 Sep 2025 04:37:04 +0300 [thread overview]
Message-ID: <aNNLQMOm_zz-3vOG@kernel.org> (raw)
In-Reply-To: <aNNKAIbzki-a121p@kernel.org>
On Wed, Sep 24, 2025 at 04:31:48AM +0300, Jarkko Sakkinen wrote:
> On Tue, Sep 23, 2025 at 08:07:41PM +0300, Jarkko Sakkinen wrote:
> > 1. These are previous changes to tpm_buf, which make stack allocations
> > much more feasible than previously.
> > 2. Migrate low-hanging fruit to use stack allocations.
> > 3. Re-orchestrate tpm_get_random().
> >
> > Jarkko Sakkinen (3):
> > tpm: Make TPM buffer allocations more robust
> > tpm: Use TPM_MIN_BUF_SIZE in driver commands
> > tpm orchestrate tpm_get_random() in the function
>
> I'm quite soon sending v12 because I randomly noticed a resource
> over-cosumption bug. which could be theoretically triggered e.g.
> via interposing a bus or a faulty device: tpm2_get_pcr_allocation()
> does not have a hard limit for the number of PCR banks.
>
> The fix:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?h=tpm-buf&id=3d92f14c204d09babadaa0b7c7a82c40d11696d0
[should have "ret = -E2BIG; goto out;". The reason for that bug is that
I just rebased the patch from tip to the bottom of the series, which
caused some merge conflicts.]
BR, Jarkko
prev parent reply other threads:[~2025-09-24 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 17:07 [PATCH v11 0/3] tpm: robust stack allocations Jarkko Sakkinen
2025-09-23 17:07 ` [PATCH v11 1/3] tpm: Make TPM buffer allocations more robust Jarkko Sakkinen
2025-09-23 17:07 ` [PATCH v11 2/3] tpm: Use TPM_MIN_BUF_SIZE in driver commands Jarkko Sakkinen
2025-09-23 17:07 ` [PATCH v11 3/3] tpm orchestrate tpm_get_random() in the function Jarkko Sakkinen
2025-09-24 1:31 ` [PATCH v11 0/3] tpm: robust stack allocations Jarkko Sakkinen
2025-09-24 1:37 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNNLQMOm_zz-3vOG@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).