From: "Serge E. Hallyn" <serge@hallyn.com>
To: Paul Moore <paul@paul-moore.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org,
Ryan Foster <foster.ryan.r@gmail.com>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] Clarify the rootid_owns_currentns
Date: Tue, 18 Nov 2025 17:59:25 -0600 [thread overview]
Message-ID: <aR0IXXF45jzoq1ZZ@mail.hallyn.com> (raw)
In-Reply-To: <CAHC9VhQu7gSVO-QZFE_iaCB0qBqB3surdHQo4Vg71zc890uEhA@mail.gmail.com>
On Tue, Nov 18, 2025 at 10:47:06AM -0500, Paul Moore wrote:
> On Tue, Nov 18, 2025 at 9:16 AM Serge E. Hallyn <serge@hallyn.com> wrote:
> > On Fri, Nov 14, 2025 at 03:33:19PM -0600, Serge E. Hallyn wrote:
> > > Split most of the rootid_owns_currentns() functionality
> > > into a more generic rootid_owns_ns() function which
> > > will be easier to write tests for.
> > >
> > > Rename the functions and variables to make clear that
> > > the ids being tested could be any uid.
> > >
> > > Signed-off-by: Serge Hallyn <serge@hallyn.com>
> > > CC: Ryan Foster <foster.ryan.r@gmail.com>
> > > CC: Christian Brauner <brauner@kernel.org>
> >
> > Paul, Christian, let me know if you have any objections, else I will
> > queue this up in caps-next.
>
> Seems reasonable to me, but it would be good to fix the parameter doc
> bug that the kernel test robot identified. I suspect it is just the
> extra vertical comment space between the top one line summary and the
> parameter list.
ooh, is that it. I couldn't for the life of me figure out what it
was complaining about. Will try that, thanks.
next prev parent reply other threads:[~2025-11-18 23:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 21:33 [PATCH] Clarify the rootid_owns_currentns Serge E. Hallyn
2025-11-14 23:16 ` kernel test robot
2025-11-18 14:16 ` Serge E. Hallyn
2025-11-18 15:47 ` Paul Moore
2025-11-18 23:59 ` Serge E. Hallyn [this message]
2025-11-19 0:05 ` Serge E. Hallyn
2025-11-19 0:29 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR0IXXF45jzoq1ZZ@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=brauner@kernel.org \
--cc=foster.ryan.r@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).