From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017CE2A1BA for ; Thu, 12 Feb 2026 01:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770859831; cv=none; b=MimtmTNJnOO9Kwt8+DPX/MaK9rzuvF/n6+jj+8ICEJg7SBzwfO5zt4Lln1vwZKLTV9TxreKKh9jRk3lX6C8YReE6OqG2bkgGphOksQMpZkE2LmWPoAy1IMCl3LjxQbPrdkekVzq24htkX7wr0X9AP8/UNi4IhSqNA6e0SZFdLvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770859831; c=relaxed/simple; bh=KgiA3wWySdtu27emmfFx9TmT091bq+yUVCdDCtZD06E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=dfC8CgDiii6Zm8Zs2P28nu0PABN6iX3fUQnrPOH8dZZnXIU5EKPYEIqU3XP1jdIOY/9MtHla/3WA2o+9B9j3uVzdu57IZRdCpmO+BYi6v8G9kUw0mlmd7cehHvBgrXPSsujrwRaqcl+wrRb8qizKxojYmqlByrcHPgKQSUuKcTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AstQJRbp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AstQJRbp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770859828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bY4z6uuO6pRuPz5GN5A8CgMrwxk/puAYj4i3AjMGr9s=; b=AstQJRbpgZMBDfedPSvIG3Xnm5M2B//WLIDQk+TQjtOT3E6HivpB5auxwSEoGzSe4NadKB 4VX0yKUdUPfE+Bo5cB8Zvun30ncCADH3u1Nmka9q4M8pdlDxKVaJGgVOJpoBiAOn5fAxAe d9b0KsQkGsIPO7slZKuV4rPPHflHXtk= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-vhi-yRu2N2CWmXx8ae6H-g-1; Wed, 11 Feb 2026 20:30:26 -0500 X-MC-Unique: vhi-yRu2N2CWmXx8ae6H-g-1 X-Mimecast-MFC-AGG-ID: vhi-yRu2N2CWmXx8ae6H-g_1770859826 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ab0b2e804cso28508425ad.3 for ; Wed, 11 Feb 2026 17:30:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770859825; x=1771464625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bY4z6uuO6pRuPz5GN5A8CgMrwxk/puAYj4i3AjMGr9s=; b=UJpHBCAngF5Cto3eOfqJk33It4rKaLH5J5u7NNaglT5V4Q2CZ7CoKwD2oCbaTMbx9R XoFmBzQx0q2pwaS6wsc6WooQiByBPyZwOfAB0Ls4DOfS98TrCOt+PAJodVA+3w5ti+Am p5yqTcZXfGmu0BtS4bJPm7ApLAgYYqh54c6seslmRqtAev1qNYj5/z54ICYhxiXpv0R3 PUWRhIVcr+paI6QPdECb0g1XIlT8Vd3+5OeVo+DdTv4bpa9MJVP5d4aCaPXaUYLJSvn6 lRjn+kUtlh2MtF3NAUBUwcjUXdydKep832AwBCC0IV2lYvfR2mHPaXnEkouMYOZwrG2E vKDw== X-Forwarded-Encrypted: i=1; AJvYcCW1hh2hC9HnZtPXsDHg7uZn+vdjFwUwwM4TQ/16u4xKSTtcAtFAHePejfP9EqVmVjNUzQexjXibee922vFuwAL8vuA42c0=@vger.kernel.org X-Gm-Message-State: AOJu0YwN06J4CHbIZ0kvq5DspQ1EqBRS/Ok1WqT2seB+cujYQYqW7o7k 4+L3ILCUMqnlZI4WO+3d69yYVlWgIhDc+swEmSiy2nj/dqNKX53AIFGdWHGBk4lTxaq0gsh+anL Q/ybt3xubsvduDBQLz1yKw67OitvbYvfwAGUOgc01VKrjxjFxg7AMm+wXv8J5YLbi+S+5N33qMp wN4A== X-Gm-Gg: AZuq6aLonOryZJXeUq0RxnltLKXmpVB1d8PQ9Wc9h2GWSUrVRh1qqAkAstViDJaN+F2 PRJmyMBE46Jk1sjBxtOkOnM0nErh7dOGYgopbp7r6PSRbpmIeAnlxOUMYsriMcuxdfRIITpbqEG IbDqlilauWrqiWdClKjspMde2HcJl4+l1JkLXeVmdZTanSTgl9gVG36dncOw6L2G7/igT0iLAfH mw+y8p1w1yR1rwwqSJK3ZX8fzF8o7j7edYi/9B/t2iM9GCRZt0lpgoLa97QiUSBOmp866fHFQvz 3pxwvGJFCGJf9R1ui1ZVOzn7DNYNa8KTVin0ikYNMGeEAPbSZVDNfGz+JiRHHH4tZkXim15tC67 DQ/W0WxfF3UUF X-Received: by 2002:a05:6a20:e20d:b0:38d:fc34:c88d with SMTP id adf61e73a8af0-3944887601cmr937844637.55.1770859825453; Wed, 11 Feb 2026 17:30:25 -0800 (PST) X-Received: by 2002:a05:6a20:e20d:b0:38d:fc34:c88d with SMTP id adf61e73a8af0-3944887601cmr937804637.55.1770859824883; Wed, 11 Feb 2026 17:30:24 -0800 (PST) Received: from localhost ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6e197f7e0bsm3248413a12.27.2026.02.11.17.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 17:30:24 -0800 (PST) Date: Thu, 12 Feb 2026 09:28:43 +0800 From: Coiby Xu To: Mimi Zohar Cc: linux-integrity@vger.kernel.org, Heiko Carstens , Alexander Egorenkov , Ard Biesheuvel , Dave Hansen , Roberto Sassu , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen , open list , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , "open list:S390 ARCHITECTURE" , "open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)" , "open list:SECURITY SUBSYSTEM" , "open list:KEYS/KEYRINGS_INTEGRITY" Subject: Re: [PATCH v2 1/3] integrity: Make arch_ima_get_secureboot integrity-wide Message-ID: References: <20260203041434.872784-1-coxu@redhat.com> <20260203041434.872784-2-coxu@redhat.com> <66f9d13875e81a965984e2a661e992a3fe43c516.camel@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <66f9d13875e81a965984e2a661e992a3fe43c516.camel@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gDGjcqDZLZjCTMGbk7kb-ETEbIx5My-Mg7EdZ7IOA2Q_1770859826 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Mon, Feb 09, 2026 at 03:43:08PM -0500, Mimi Zohar wrote: >On Tue, 2026-02-03 at 12:14 +0800, Coiby Xu wrote: >> EVM and other LSMs need the ability to query the secure boot status of >> the system, without directly calling the IMA arch_ima_get_secureboot >> function. Refactor the secure boot status check into a general function >> named arch_get_secureboot. >> >> Reported-and-suggested-by: Mimi Zohar >> Suggested-by: Roberto Sassu >> Signed-off-by: Coiby Xu > >Thanks, Coiby. Other than unnecessarily splitting a line, the patch set looks >good. As soon as the open window closes, I'll queue these patches for linux- >next. Hi Mimi, thanks for reviewing the patch set! Would you like me to send a new version with the line splitting issue fixed? > >> diff --git a/security/integrity/ima/ima_efi.c b/security/integrity/ima/ima_efi.c >> index 138029bfcce1..27521d665d33 100644 >> --- a/security/integrity/ima/ima_efi.c >> +++ b/security/integrity/ima/ima_efi.c [...] >> { >> - if (IS_ENABLED(CONFIG_IMA_ARCH_POLICY) && arch_ima_get_secureboot()) { >> + if (IS_ENABLED(CONFIG_IMA_ARCH_POLICY) && >> + arch_get_secureboot()) { > >No need to split the line here or below. > > >> if (IS_ENABLED(CONFIG_MODULE_SIG)) >> set_module_sig_enforced(); >> if (IS_ENABLED(CONFIG_KEXEC_SIG)) >> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c >> index 5770cf691912..6d093ac82a45 100644 >> --- a/security/integrity/ima/ima_main.c >> +++ b/security/integrity/ima/ima_main.c >> @@ -949,8 +949,8 @@ static int ima_load_data(enum kernel_load_data_id id, bool contents) >> >> switch (id) { >> case LOADING_KEXEC_IMAGE: >> - if (IS_ENABLED(CONFIG_KEXEC_SIG) >> - && arch_ima_get_secureboot()) { >> + if (IS_ENABLED(CONFIG_KEXEC_SIG) && >> + arch_get_secureboot()) { > >===> > >Mimi > >> pr_err("impossible to appraise a kernel image without a file descriptor; try using kexec_file_load syscall.\n"); >> return -EACCES; >> } > -- Best regards, Coiby